[orca] Fix regression in combobox presentation



commit 8ab8a4fcb109f6260e594649c94435a523c0e60e
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Wed Jun 19 14:14:47 2019 -0400

    Fix regression in combobox presentation

 src/orca/scripts/web/braille_generator.py | 2 +-
 src/orca/scripts/web/speech_generator.py  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/scripts/web/braille_generator.py b/src/orca/scripts/web/braille_generator.py
index 0c8c12461..d5db779e8 100644
--- a/src/orca/scripts/web/braille_generator.py
+++ b/src/orca/scripts/web/braille_generator.py
@@ -142,7 +142,7 @@ class BrailleGenerator(braille_generator.BrailleGenerator):
         if self._script.utilities.preferDescriptionOverName(obj):
             return [obj.description]
 
-        if not self._script.utilities.hasValidName(obj):
+        if obj.name and not self._script.utilities.hasValidName(obj):
             return []
 
         return super()._generateName(obj, **args)
diff --git a/src/orca/scripts/web/speech_generator.py b/src/orca/scripts/web/speech_generator.py
index 0f5db4a5f..cdccce958 100644
--- a/src/orca/scripts/web/speech_generator.py
+++ b/src/orca/scripts/web/speech_generator.py
@@ -185,7 +185,7 @@ class SpeechGenerator(speech_generator.SpeechGenerator):
            and not self._script.utilities.isDPub(obj):
             return []
 
-        if not self._script.utilities.hasValidName(obj):
+        if obj.name and not self._script.utilities.hasValidName(obj):
             return []
 
         if obj.parent and obj.name and obj.name == obj.parent.name \


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]