[sysprof] tracefd: use g_strdup_printf()
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [sysprof] tracefd: use g_strdup_printf()
- Date: Wed, 12 Jun 2019 18:14:36 +0000 (UTC)
commit 4a31b934be22e161eaaab70746cf9cafebdfb0bb
Author: Christian Hergert <chergert redhat com>
Date: Wed Jun 12 11:13:44 2019 -0700
tracefd: use g_strdup_printf()
I don't like maintaining stack based string allocations unless it's really
a performance savings.
src/libsysprof/sysprof-tracefd-source.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/libsysprof/sysprof-tracefd-source.c b/src/libsysprof/sysprof-tracefd-source.c
index 15c8e04..31197c7 100644
--- a/src/libsysprof/sysprof-tracefd-source.c
+++ b/src/libsysprof/sysprof-tracefd-source.c
@@ -168,7 +168,7 @@ sysprof_tracefd_source_modify_spawn (SysprofSource *source,
{
SysprofTracefdSource *self = (SysprofTracefdSource *)source;
SysprofTracefdSourcePrivate *priv = sysprof_tracefd_source_get_instance_private (self);
- gchar fdstr[12];
+ g_autofree gchar *fdstr = NULL;
gint dest_fd;
gint fd;
@@ -192,7 +192,7 @@ sysprof_tracefd_source_modify_spawn (SysprofSource *source,
}
dest_fd = sysprof_spawnable_take_fd (spawnable, fd, -1);
- g_snprintf (fdstr, sizeof fdstr, "%d", dest_fd);
+ fdstr = g_strdup_printf ("%u", dest_fd);
sysprof_spawnable_setenv (spawnable, priv->envvar, fdstr);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]