[epiphany/mcatanzaro/web-apps-again-again-again: 31/33] profile-migrator: add FIXME comment



commit 701c561b9516e48f5de86441a9697797f79921ee
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Fri May 24 14:33:01 2019 -0500

    profile-migrator: add FIXME comment
    
    The legacy profile dir just returns the current profile dir, or the
    legacy default profile dir when run without a profile dir. That's
    obviously not correct since the legacy profile dir is not necessarily
    the current profile dir. It leads to some harmless but unexpected
    behavior, and it's fragile. Sadly this is not straightforward to
    implement correctly, so just add a FIXME for now.

 src/profile-migrator/ephy-profile-migrator.c | 2 ++
 1 file changed, 2 insertions(+)
---
diff --git a/src/profile-migrator/ephy-profile-migrator.c b/src/profile-migrator/ephy-profile-migrator.c
index d75163b9f..7f2669175 100644
--- a/src/profile-migrator/ephy-profile-migrator.c
+++ b/src/profile-migrator/ephy-profile-migrator.c
@@ -75,6 +75,8 @@ legacy_profile_dir (void)
   static char *dir = NULL;
   if (dir == NULL)
     {
+      /* FIXME: This is fragile and not correct.
+       */
       if (profile_dir != NULL)
         {
           dir = profile_dir;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]