[evince/1179-evince-3-32-on-fedora-30-does-not-search-cyrillic-text-gnome-3-32] require Poppler 0.76.0 for ignoreDiacritics feature



commit 906d975769187d8466ec273d5b1cc177c2d11eda
Author: Nelson Benítez León <nbenitezl gmail com>
Date:   Thu Jun 6 20:22:09 2019 -0400

    require Poppler 0.76.0 for ignoreDiacritics feature
    
    instead of 0.73.0 (where it was first implemented)
    because 0.76.0 includes a fix for a regression that
    caused non-ascii search terms (like in eg. Russian)
    to not match anything when using the ignoreDiacritics
    option.
    
    The workaround is to use the 'case sensitive' search
    option (because using 'case sensitive' automatically
    disables ignoreDiacritics inside Poppler).
    
    But given that Fedora 30 (and probably other distros)
    ship Poppler 0.73.0, we better require the regression
    fixed version of Poppler, so to not regress on users
    which search text in the affected languages.
    
    Issue #1179

 backend/pdf/ev-poppler.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/backend/pdf/ev-poppler.cc b/backend/pdf/ev-poppler.cc
index 96111aed..8f2e9804 100644
--- a/backend/pdf/ev-poppler.cc
+++ b/backend/pdf/ev-poppler.cc
@@ -1960,7 +1960,7 @@ pdf_document_find_find_text_with_options (EvDocumentFind *document_find,
 
        if (options & EV_FIND_CASE_SENSITIVE)
                find_flags |= POPPLER_FIND_CASE_SENSITIVE;
-#if POPPLER_CHECK_VERSION(0, 73, 0)
+#if POPPLER_CHECK_VERSION(0, 76, 0)
        else    /* When search is not case sensitive, do also ignore diacritics
                to broaden our search in order to match on more expected results */
                find_flags |= POPPLER_FIND_IGNORE_DIACRITICS;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]