[balsa] Remove redundant declarations
- From: Peter Bloomfield <peterb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa] Remove redundant declarations
- Date: Tue, 4 Jun 2019 22:11:51 +0000 (UTC)
commit c77e5e52ff53e7ec1ec3dcd91a30febe2a3a1c70
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Tue Jun 4 18:09:59 2019 -0400
Remove redundant declarations
and rename libbalsa_identity_new_config() to libbalsa_identity_new_from_config().
* libbalsa/identity.c (libbalsa_identity_new_from_config):
* libbalsa/identity.h:
* src/save-restore.c (config_identity_load), (config_identities_load):
ChangeLog | 12 ++++++++++++
libbalsa/identity.c | 6 ++----
libbalsa/identity.h | 3 ---
src/save-restore.c | 4 ++--
4 files changed, 16 insertions(+), 9 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d8e52c8da..652d7f3d6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2019-06-04 Peter Bloomfield <pbloomfield bellsouth net>
+
+ Remove redundant declarations
+
+ and rename libbalsa_identity_new_config() to
+ libbalsa_identity_new_from_config().
+
+ * libbalsa/identity.c (libbalsa_identity_new_from_config):
+ * libbalsa/identity.h:
+ * src/save-restore.c (config_identity_load),
+ (config_identities_load):
+
2019-06-04 Peter Bloomfield <pbloomfield bellsouth net>
Use G_DECLARE_FINAL_TYPE to declare LibBalsaIdentity
diff --git a/libbalsa/identity.c b/libbalsa/identity.c
index e811a4d39..4833ca2d8 100644
--- a/libbalsa/identity.c
+++ b/libbalsa/identity.c
@@ -88,8 +88,6 @@ struct _LibBalsaIdentity {
};
/* Forward references. */
-static void libbalsa_identity_class_init(LibBalsaIdentityClass* klass);
-static void libbalsa_identity_init(LibBalsaIdentity* ident);
static void libbalsa_identity_finalize(GObject* object);
G_DEFINE_TYPE(LibBalsaIdentity, libbalsa_identity, G_TYPE_OBJECT)
@@ -1879,12 +1877,12 @@ display_frame_set_path(GObject * dialog,
}
-/* libbalsa_identity_new_config:
+/* libbalsa_identity_new_from_config:
factory-type method creating new Identity object from given
configuration data.
*/
LibBalsaIdentity*
-libbalsa_identity_new_config(const gchar* name)
+libbalsa_identity_new_from_config(const gchar* name)
{
LibBalsaIdentity* ident;
gchar *fname, *email;
diff --git a/libbalsa/identity.h b/libbalsa/identity.h
index 9535a29ad..c3b4135ef 100644
--- a/libbalsa/identity.h
+++ b/libbalsa/identity.h
@@ -71,9 +71,6 @@ GtkWidget * libbalsa_identity_combo_box(GList * identities,
GCallback changed_cb,
gpointer changed_data);
-LibBalsaIdentity* libbalsa_identity_new_config(const gchar* name);
-void libbalsa_identity_save(LibBalsaIdentity* id, const gchar* prefix);
-
/*
* Getters
*/
diff --git a/src/save-restore.c b/src/save-restore.c
index 3ecc19dac..20e9972df 100644
--- a/src/save-restore.c
+++ b/src/save-restore.c
@@ -1657,7 +1657,7 @@ config_identity_load(const gchar * key, const gchar * value, gpointer data)
gchar *smtp_server_name;
libbalsa_conf_push_group(key);
- ident = libbalsa_identity_new_config(value);
+ ident = libbalsa_identity_new_from_config(value);
smtp_server_name = libbalsa_conf_get_string("SmtpServer");
libbalsa_identity_set_smtp_server(ident,
find_smtp_server_by_name
@@ -1694,7 +1694,7 @@ config_identities_load()
libbalsa_conf_push_group("identity-default");
balsa_app.identities =
g_list_prepend(NULL,
- libbalsa_identity_new_config("default"));
+ libbalsa_identity_new_from_config("default"));
libbalsa_conf_pop_group();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]