[gnome-music/wip/jfelder/starhandlerwidget-try] starhandlerwidget: Catch the correct error in on_star_toggled



commit e6377de93c8b5ced2a8717dd9bddd58a07ef0ad9
Author: Jean Felder <jfelder src gnome org>
Date:   Sun Jun 2 20:34:40 2019 +0200

    starhandlerwidget: Catch the correct error in on_star_toggled
    
    The get_iter method of a GtkTreeModel raises a ValueError if the path
    does not exist.
    
    This fix prevents the crash mentioned in #264 but it does not solve
    the underlying issue.
    
    Related: #264

 gnomemusic/widgets/starhandlerwidget.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gnomemusic/widgets/starhandlerwidget.py b/gnomemusic/widgets/starhandlerwidget.py
index e55af8c7..f9698598 100644
--- a/gnomemusic/widgets/starhandlerwidget.py
+++ b/gnomemusic/widgets/starhandlerwidget.py
@@ -139,7 +139,7 @@ class StarHandlerWidget(object):
         """Called if a star is clicked"""
         try:
             _iter = self._parent.model.get_iter(path)
-        except TypeError:
+        except ValueError:
             return
 
         try:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]