[vte/wip/egmont/bidi: 20/21] doc

[Egmont Koblinger <egmontkob src gnome org>]

commit 5423f2a6c4de391880b2b5a98125a03a36ef6508
Author: Egmont Koblinger <egmont gmail com>
Date:   Tue May 28 14:40:57 2019 +0200

    doc

 BIDI-STATUS    | 7 +++----
 src/bidi.cc    | 3 ++-
 src/vte.cc     | 3 ++-
 src/vtedraw.cc | 1 -
 4 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/BIDI-STATUS b/BIDI-STATUS
index 1a29c4f4..4f9b665a 100644
--- a/BIDI-STATUS
+++ b/BIDI-STATUS
@@ -1,6 +1,6 @@
 Done:
 - Implicit (level 1) and Explicit (a small subset only) modes (SM / RM 8).
-- Overall LTR or RTL direction (SPD 0 / 3 or SCP 1 / 2).
+- Overall LTR or RTL direction (SCP 1 / 2 or SPD 0 / 3).
 - Possibility to autodetect paragraph direction (DECSET / DECRST 2501).
 - Possibility to make box drawing characters mirrorable (DECSET / DECRST 2500).
 - I-Beam cursor shows the character's resolved directionality when the
@@ -19,7 +19,8 @@ Bugs:
 - The way the modes apply to paragraphs, and what happens when a paragraph
   is split or two paragraphs are joined is just a first hack, needs to be
   reviewed, adjusted, fixed properly.
-- SPD should also update all the onscreen lines.
+- SPD should also update all the onscreen lines – really?
+- Or should we drop SPD?
 
 Missing from first release:
 - The entire screen is always invalidated. Have some more fine grained
@@ -27,8 +28,6 @@ Missing from first release:
 - Probably we'd need to make Erase in Display (Below or All) sequences turn
   the previous line to hard wrapped, requiring to keep one more line in the
   ring's writable area.
-- Design doc review & publishing, public tracking issue.
-- Brief summary about the design and implemented features in the source tree.
 - Code cleanup and review, of course.
 
 Planned future improvements:
diff --git a/src/bidi.cc b/src/bidi.cc
index 1a3b0ee8..f902dc67 100644
--- a/src/bidi.cc
+++ b/src/bidi.cc
@@ -20,7 +20,8 @@
  * This class implements mapping the logical letters to their visual positions
  * according to the modes tracked for each paragraph.
  *
- * BiDi is implemented according to https://terminal-wg.pages.freedesktop.org/bidi/
+ * BiDi is implemented according to Terminal-wg/bidi v0.2:
+ * https://terminal-wg.pages.freedesktop.org/bidi/
  */
 
 #include <config.h>
diff --git a/src/vte.cc b/src/vte.cc
index 26c3c557..9a9b15dd 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -1709,7 +1709,8 @@ Terminal::confine_grid_coords(vte::grid::coords const& rowcol) const
  * Left/start margin or anything further to the left/start is denoted by column -1's right half,
  * right/end margin or anything further to the right/end is denoted by column m_column_count's left half.
  *
- * BiDi: returns logical (start/end) position for normal selection modes, visual (left/right) position for 
block mode.
+ * BiDi: returns logical position (start or end) for normal selection modes, visual position (left or
+ * right) for block mode.
  */
 vte::grid::halfcoords
 Terminal::selection_grid_halfcoords_from_view_coords(vte::view::coords const& pos) const
diff --git a/src/vtedraw.cc b/src/vtedraw.cc
index aafb012b..6314c956 100644
--- a/src/vtedraw.cc
+++ b/src/vtedraw.cc
@@ -1490,7 +1490,6 @@ _vte_draw_text_internal (struct _vte_draw *draw,
                vteunistr c = requests[i].c;
 
                 if (G_UNLIKELY (requests[i].mirror)) {
-                        // FIXME what if 'c' is actually a real vteunistr?
                         vte_bidi_get_mirror_char (c, requests[i].box_mirror, &c);
                 }