[orca: 1/2] Fix confusion between shift and shiftlock



commit 122edc1c6b1f853641c8f7aaea28fe8e550d6a08
Author: Samuel Thibault <samuel thibault ens-lyon org>
Date:   Mon Jul 22 17:34:06 2019 +0200

    Fix confusion between shift and shiftlock
    
    The shift lock modifier does not appear as the shift modifier.
    It will appear as the Orca modifier, so we do not need to test for this
    separately anyway.
    
    Fixes #49

 src/orca/keybindings.py | 10 ----------
 1 file changed, 10 deletions(-)
---
diff --git a/src/orca/keybindings.py b/src/orca/keybindings.py
index ff471ef05..5bb5dfba0 100644
--- a/src/orca/keybindings.py
+++ b/src/orca/keybindings.py
@@ -131,10 +131,6 @@ def getModifierNames(mods):
     """Gets the modifier names of a numeric modifier mask as a human
     consumable string.
     """
-    try:
-        shiftmask = 1 << pyatspi.MODIFIER_SHIFT
-    except:
-        shiftmask = 0
 
     text = ""
     if mods & ORCA_MODIFIER_MASK:
@@ -151,12 +147,6 @@ def getModifierNames(mods):
         # "caps lock" modifier.
         #
         text += _("Caps_Lock") + "+"
-    elif mods & shiftmask:
-        # Translators: this is presented in a GUI to represent the
-        # "shift lock" modifier. There is no reason to make it different from
-        # the translation for "Caps_Lock"
-        #
-        text += _("Shift_Lock") + "+"
     #if mods & (1 << pyatspi.MODIFIER_NUMLOCK):
     #    text += _("Num_Lock") + "+"
     if mods & 128:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]