[gnome-shell/wip/lantw/main-avoid-missing-braces-warnings-when-compiling-with-clang] main: Avoid missing braces warnings when compiling with clang



commit 0bfc9fe2b1575598adc3b818ab17243d9f35b744
Author: Ting-Wei Lan <lantw src gnome org>
Date:   Sat Jul 20 16:28:53 2019 +0800

    main: Avoid missing braces warnings when compiling with clang
    
    Since -Werror=missing-braces is used, having missing braces warnings
    aren't allowed. However, the first member of struct sigaction is a union
    whose first member is a pointer, causing clang to produce warnings when
    it is initialized to { 0 }.
    
    Instead of initializing to a zero value, we can specify values of
    members directly in the initializer to avoid warnings.

 src/main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/main.c b/src/main.c
index 8d144aac6..aa0484656 100644
--- a/src/main.c
+++ b/src/main.c
@@ -372,7 +372,7 @@ dump_gjs_stack_alarm_sigaction (int signo)
 static void
 dump_gjs_stack_on_signal_handler (int signo)
 {
-  struct sigaction sa = { 0 };
+  struct sigaction sa = { .sa_handler = dump_gjs_stack_alarm_sigaction };
   gsize i;
 
   /* Ignore all the signals starting this point, a part the one we'll raise
@@ -388,7 +388,6 @@ dump_gjs_stack_on_signal_handler (int signo)
 
   /* Waiting at least 5 seconds for the dumpstack, if it fails, we raise the error */
   caught_signal = signo;
-  sa.sa_handler = dump_gjs_stack_alarm_sigaction;
   sigemptyset (&sa.sa_mask);
   sigaction (SIGALRM, &sa, NULL);
 
@@ -402,10 +401,11 @@ dump_gjs_stack_on_signal_handler (int signo)
 static void
 dump_gjs_stack_on_signal (int signo)
 {
-  struct sigaction sa = { 0 };
+  struct sigaction sa = {
+    .sa_flags   = SA_RESETHAND | SA_NODEFER,
+    .sa_handler = dump_gjs_stack_on_signal_handler,
+  };
 
-  sa.sa_flags   = SA_RESETHAND | SA_NODEFER;
-  sa.sa_handler = dump_gjs_stack_on_signal_handler;
   sigemptyset (&sa.sa_mask);
 
   sigaction (signo, &sa, NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]