[odrs-web/oscp] Never allow zero sized reviews
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [odrs-web/oscp] Never allow zero sized reviews
- Date: Fri, 19 Jul 2019 15:58:28 +0000 (UTC)
commit 3278fb5fdffb10fd09434ff52887d9530e9e8e16
Author: Richard Hughes <richard hughsie com>
Date: Fri Jul 19 11:29:57 2019 +0100
Never allow zero sized reviews
Some new software center is uploading invalid reports...
app_data/odrs/views_api.py | 4 ++++
1 file changed, 4 insertions(+)
---
diff --git a/app_data/odrs/views_api.py b/app_data/odrs/views_api.py
index 6edd8c9..10ad680 100644
--- a/app_data/odrs/views_api.py
+++ b/app_data/odrs/views_api.py
@@ -126,7 +126,11 @@ def api_submit():
review = Review()
review.locale = item['locale']
review.summary = _sanitised_summary(item['summary'])
+ if len(review.summary) < 2:
+ return json_error('summary is too short')
review.description = _sanitised_description(item['description'])
+ if len(review.description) < 2:
+ return json_error('description is too short')
review.user_id = user.user_id
review.version = _sanitised_version(item['version'])
review.distro = item['distro']
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]