[epiphany/mcatanzaro/asan: 21/31] Most visited: fix remove buttons on thumbnails

[Michael Catanzaro <mcatanzaro src gnome org>]

commit cec58b1fa743e004f8ff2c951cfca246574009d8
Author: Tobias Bernard <tbernard gnome org>
Date:   Thu Jul 11 20:31:58 2019 +0200

    Most visited: fix remove buttons on thumbnails
    
    - replace x character with SVG icon for nicer rendering
    - make the button an actual circle
    - slightly darker hover state background color for better contrast

 embed/ephy-about-handler.c             |  2 +-
 src/resources/about.css                | 13 +++----
 src/resources/epiphany.gresource.xml   |  1 +
 src/resources/overview-remove-item.svg | 64 ++++++++++++++++++++++++++++++++++
 4 files changed, 70 insertions(+), 10 deletions(-)
---
diff --git a/embed/ephy-about-handler.c b/embed/ephy-about-handler.c
index 0ff3d7f20..8a40b0d40 100644
--- a/embed/ephy-about-handler.c
+++ b/embed/ephy-about-handler.c
@@ -406,7 +406,7 @@ history_service_query_urls_cb (EphyHistoryService     *history,
 
     g_string_append_printf (data_str,
                             "<a class=\"overview-item\" title=\"%s\" href=\"%s\">"
-                            "  <div class=\"overview-close-button\" title=\"%s\">&#10006;</div>"
+                            "  <div class=\"overview-close-button\" title=\"%s\"></div>"
                             "  <span class=\"overview-thumbnail\"%s></span>"
                             "  <span class=\"overview-title\">%s</span>"
                             "</a>",
diff --git a/src/resources/about.css b/src/resources/about.css
index ad2e198e3..68ad82fb8 100644
--- a/src/resources/about.css
+++ b/src/resources/about.css
@@ -270,19 +270,14 @@ html.epiphany-html {
     opacity: 0;
     z-index: 5;
     color: #888;
-    font-family: -webkit-system-font, Cantarell, sans-serif;
-    font-size: 14px;
-    width: 13px;
-    height: 14px;
-    color: #fff;
-    padding: 3px 3px 4px 4px;
-    text-shadow: 0 1px 0 rgba(0,0,0,.3);
-    background-color: rgba(80,80,80,.2);
+    width: 24px;
+    height: 24px;
+    background: url(ephy-resource:///org/gnome/epiphany/overview-remove-item.svg) center no-repeat, 
rgba(80,80,80,.3);
     border-radius: 50%;
 }
 
 .overview-close-button:hover {
-    background-color: rgba(0,0,0,.8);
+    background: url(ephy-resource:///org/gnome/epiphany/overview-remove-item.svg) center no-repeat, 
rgba(0,0,0,.8);
 }
 
 .overview-close-button:active {
diff --git a/src/resources/epiphany.gresource.xml b/src/resources/epiphany.gresource.xml
index 2b5b4ead7..bcc10d7bc 100644
--- a/src/resources/epiphany.gresource.xml
+++ b/src/resources/epiphany.gresource.xml
@@ -5,6 +5,7 @@
     <file>computer-fail-symbolic.png</file>
     <file preprocess="xml-stripblanks" compressed="true">private-mode.svg</file>
     <file preprocess="xml-stripblanks" compressed="true">web-watermark.svg</file>
+    <file preprocess="xml-stripblanks" compressed="true">overview-remove-item.svg</file>
     <file>network-error-symbolic.png</file>
     <file>security-high-symbolic.png</file>
     <file compressed="true">about.ini</file>
diff --git a/src/resources/overview-remove-item.svg b/src/resources/overview-remove-item.svg
new file mode 100644
index 000000000..349166b12
--- /dev/null
+++ b/src/resources/overview-remove-item.svg
@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+   xmlns:dc="http://purl.org/dc/elements/1.1/";
+   xmlns:cc="http://creativecommons.org/ns#";
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";
+   xmlns:svg="http://www.w3.org/2000/svg";
+   xmlns="http://www.w3.org/2000/svg";
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd";
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape";
+   height="16"
+   id="svg7384"
+   version="1.1"
+   width="16"
+   sodipodi:docname="overview-remove-item.svg"
+   inkscape:version="0.92.4 (5da689c313, 2019-01-14)">
+  <sodipodi:namedview
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1"
+     objecttolerance="10"
+     gridtolerance="10"
+     guidetolerance="10"
+     inkscape:pageopacity="0"
+     inkscape:pageshadow="2"
+     inkscape:window-width="1920"
+     inkscape:window-height="1016"
+     id="namedview8"
+     showgrid="false"
+     inkscape:zoom="41.7193"
+     inkscape:cx="4.3011226"
+     inkscape:cy="7.5482036"
+     inkscape:window-x="0"
+     inkscape:window-y="27"
+     inkscape:window-maximized="1"
+     inkscape:current-layer="svg7384" />
+  <metadata
+     id="metadata90">
+    <rdf:RDF>
+      <cc:Work
+         rdf:about="">
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type
+           rdf:resource="http://purl.org/dc/dcmitype/StillImage"; />
+        <dc:title>Gnome Symbolic Icon Theme</dc:title>
+      </cc:Work>
+    </rdf:RDF>
+  </metadata>
+  <title
+     id="title9167">Gnome Symbolic Icon Theme</title>
+  <defs
+     id="defs7386" />
+  <g
+     id="g4572">
+    <path
+       d="m 4,5 h 1 c 0.01037,-1.2e-4 0.02079,-4.6e-4 0.03125,0 0.254951,0.0112 0.50987,0.12858 
0.6875,0.3125 L 8,7.59375 10.3125,5.3125 C 10.578125,5.082 10.759172,5.007 11,5 h 1 v 1 c 0,0.28647 
-0.03434,0.55065 -0.25,0.75 l -2.28125,2.28125 2.25,2.25 C 11.906938,11.46942 11.999992,11.7347 12,12 v 1 h 
-1 c -0.265301,-10e-6 -0.530586,-0.0931 -0.71875,-0.28125 L 8,10.4375 5.71875,12.71875 C 5.530586,12.90694 
5.26529,13 5,13 H 4 v -1 c -3e-6,-0.26529 0.09306,-0.53058 0.28125,-0.71875 L 6.5625,9.03125 4.28125,6.75 C 
4.070508,6.55537 3.97809,6.28075 4,6 Z"
+       id="path814"
+       
style="color:#bebebe;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:'Andale
 Mono';-inkscape-font-specification:'Andale 
Mono';text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;text-anchor:start;display:inline;overflow:visible;visibility:visible;fill:#000000;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1.78124988;marker:none;enable-background:new;opacity:0.3"
+       inkscape:connector-curvature="0" />
+    <path
+       
style="color:#bebebe;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:'Andale
 Mono';-inkscape-font-specification:'Andale 
Mono';text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;text-anchor:start;display:inline;overflow:visible;visibility:visible;fill:#ffffff;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1.78124988;marker:none;enable-background:new"
+       id="path10839-9"
+       d="m 4,4 h 1 c 0.01037,-1.2e-4 0.02079,-4.6e-4 0.03125,0 0.254951,0.0112 0.50987,0.12858 
0.6875,0.3125 L 8,6.59375 10.3125,4.3125 C 10.578125,4.082 10.759172,4.007 11,4 h 1 v 1 c 0,0.28647 
-0.03434,0.55065 -0.25,0.75 l -2.28125,2.28125 2.25,2.25 C 11.906938,10.46942 11.999992,10.7347 12,11 v 1 h 
-1 c -0.265301,-10e-6 -0.530586,-0.0931 -0.71875,-0.28125 L 8,9.4375 5.71875,11.71875 C 5.530586,11.90694 
5.26529,12 5,12 H 4 v -1 c -3e-6,-0.26529 0.09306,-0.53058 0.28125,-0.71875 L 6.5625,8.03125 4.28125,5.75 C 
4.070508,5.55537 3.97809,5.28075 4,5 Z" />
+  </g>
+</svg>