[gnome-flashback/gnome-3-28] input-sources: avoid unneeded status icon re-creation

[Alberts Muktupāvels <muktupavels src gnome org>]

commit fdecddfa802bbbf1b45daf95af121abe72002df6
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date:   Sat May 11 14:57:56 2019 +0300

    input-sources: avoid unneeded status icon re-creation
    
    When we get sources-changed signal current source returned by
    gf_input_source_manager_get_current_source will be NULL and status
    icon will be destroyed. After that we will get current-source-changed
    signal and status icon will be re-created causing flickering effect.
    
    Fix this by not connecting to sources-changed signal.
    
    https://gitlab.gnome.org/GNOME/gnome-flashback/issues/16

 gnome-flashback/libinput-sources/gf-input-sources.c | 10 ----------
 1 file changed, 10 deletions(-)
---
diff --git a/gnome-flashback/libinput-sources/gf-input-sources.c 
b/gnome-flashback/libinput-sources/gf-input-sources.c
index e54e3b4..40c352c 100644
--- a/gnome-flashback/libinput-sources/gf-input-sources.c
+++ b/gnome-flashback/libinput-sources/gf-input-sources.c
@@ -872,13 +872,6 @@ update_status_icon (GfInputSources *sources)
   g_free (icon_name);
 }
 
-static void
-sources_changed_cb (GfInputSourceManager *manager,
-                    GfInputSources       *sources)
-{
-  update_status_icon (sources);
-}
-
 static void
 current_source_changed_cb (GfInputSourceManager *manager,
                            GfInputSource        *old_source,
@@ -954,9 +947,6 @@ gf_input_sources_init (GfInputSources *sources)
   gtk_icon_theme_append_search_path (gtk_icon_theme_get_default (),
                                      sources->icon_theme_path);
 
-  g_signal_connect (sources->input_source_manager, "sources-changed",
-                    G_CALLBACK (sources_changed_cb), sources);
-
   g_signal_connect (sources->input_source_manager, "current-source-changed",
                     G_CALLBACK (current_source_changed_cb), sources);