[gnome-software/wip/hughsie/flatpak-progress: 17/17] flatpak: Never show the progress bar going backwards



commit 142c41aba0d83af44d7cf0ac69a7d25e01fc89b5
Author: Richard Hughes <richard hughsie com>
Date:   Mon Apr 29 15:48:05 2019 +0100

    flatpak: Never show the progress bar going backwards
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-software/issues/650

 plugins/flatpak/gs-flatpak-transaction.c | 6 ++++++
 1 file changed, 6 insertions(+)
---
diff --git a/plugins/flatpak/gs-flatpak-transaction.c b/plugins/flatpak/gs-flatpak-transaction.c
index 45937125..c6b49909 100644
--- a/plugins/flatpak/gs-flatpak-transaction.c
+++ b/plugins/flatpak/gs-flatpak-transaction.c
@@ -156,6 +156,12 @@ _transaction_progress_changed_cb (FlatpakTransactionProgress *progress,
        guint percent = flatpak_transaction_progress_get_progress (progress);
        if (flatpak_transaction_progress_get_is_estimating (progress))
                return;
+       if (gs_app_get_progress (app) != 100 &&
+           gs_app_get_progress (app) > percent) {
+               g_warning ("ignoring percentage %u%% -> %u%% as going down...",
+                          gs_app_get_progress (app), percent);
+               return;
+       }
        gs_app_set_progress (app, percent);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]