[grilo-plugins/wip/hadess/chromaprint-missing-decoders] chromaprint: Throw an error on missing decoders



commit 4564c08e3369cda3d031f983f5bb40eec7a0e60c
Author: Bastien Nocera <hadess hadess net>
Date:   Wed Jul 17 16:26:50 2019 +0200

    chromaprint: Throw an error on missing decoders
    
    Closes: #47

 tests/chromaprint/test_chromaprint_resolve.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/tests/chromaprint/test_chromaprint_resolve.c b/tests/chromaprint/test_chromaprint_resolve.c
index 499e9edd..36807086 100644
--- a/tests/chromaprint/test_chromaprint_resolve.c
+++ b/tests/chromaprint/test_chromaprint_resolve.c
@@ -55,6 +55,9 @@ get_chromaprint_fingerprint (GrlSource   *source,
                            options,
                            NULL);
 
+  if (!grl_data_has_key (GRL_DATA (audio), GRL_METADATA_KEY_DURATION))
+    g_error ("Necessary audio decoders not installed, verify your installation");
+
   *duration = grl_media_get_duration (GRL_MEDIA (audio));
   *fingerprint = g_strdup (grl_data_get_string (GRL_DATA (audio),
                                                 key_fingerprint));
@@ -69,9 +72,6 @@ test_fingerprint (void)
   GrlSource *source;
   guint i;
 
-  /* FIXME: We should probably check in the tests if tester has decoder
-   * for flac and ogg */
-
   struct {
     gchar *url;
     gint   duration;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]