[NetworkManager-fortisslvpn] pppd-plugin: use unsigned to count through routes.



commit c3de9c34e58f2ecc8b880193ad043f605d7b7720
Author: Berend De Schouwer <berend deschouwer co za>
Date:   Tue Apr 23 09:45:06 2019 +0200

    pppd-plugin: use unsigned to count through routes.
    
    We will never see a negative route environment variable (VPN_ROUTE_DEST_-1),
    so make the variable unsigned.
    
    https://gitlab.gnome.org/GNOME/NetworkManager-fortisslvpn/issues/14
    https://gitlab.gnome.org/GNOME/NetworkManager-fortisslvpn/merge_requests/10

 src/nm-fortisslvpn-pppd-plugin.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/nm-fortisslvpn-pppd-plugin.c b/src/nm-fortisslvpn-pppd-plugin.c
index 953541d..e589615 100644
--- a/src/nm-fortisslvpn-pppd-plugin.c
+++ b/src/nm-fortisslvpn-pppd-plugin.c
@@ -235,7 +235,7 @@ get_ip4_routes (in_addr_t ouraddr)
 {
        GVariantBuilder builder;
        GVariant *value;
-       int i;
+       guint i;
 
        g_variant_builder_init (&builder, G_VARIANT_TYPE ("aau"));
 
@@ -246,14 +246,14 @@ get_ip4_routes (in_addr_t ouraddr)
                in_addr_t dest, gateway;
                guint32 metric, prefix;
 
-               var = g_strdup_printf ("VPN_ROUTE_DEST_%d", i);
+               var = g_strdup_printf ("VPN_ROUTE_DEST_%u", i);
                str = g_getenv (var);
                g_free (var);
                if (!str || !*str)
                        break;
                dest = inet_addr (str);
 
-               var = g_strdup_printf ("VPN_ROUTE_MASK_%d", i);
+               var = g_strdup_printf ("VPN_ROUTE_MASK_%u", i);
                str = g_getenv (var);
                g_free (var);
                if (!str || !*str)
@@ -261,7 +261,7 @@ get_ip4_routes (in_addr_t ouraddr)
                else
                        prefix = nm_utils_ip4_netmask_to_prefix (inet_addr (str));
 
-               var = g_strdup_printf ("VPN_ROUTE_GATEWAY_%d", i);
+               var = g_strdup_printf ("VPN_ROUTE_GATEWAY_%u", i);
                str = g_getenv (var);
                g_free (var);
                if (!str || !*str)
@@ -269,7 +269,7 @@ get_ip4_routes (in_addr_t ouraddr)
                else
                        gateway = inet_addr (str);
 
-               var = g_strdup_printf ("VPN_ROUTE_METRIC_%d", i);
+               var = g_strdup_printf ("VPN_ROUTE_METRIC_%u", i);
                str = g_getenv (var);
                g_free (var);
                if (!str || !*str)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]