[polari] cleanup: Stop using hasOwnProperty() on target object



commit a191adfb456c46f1ec8c9b58cf997f11feb12fad
Author: Florian Müllner <fmuellner gnome org>
Date:   Sat Jun 29 03:53:02 2019 +0200

    cleanup: Stop using hasOwnProperty() on target object
    
    eslint added a new rule that forbids this. We aren't calling it on
    arbitrary data we received from untrustful sources, so it's not really
    relevant for us. Still, we can easily replace the couple of places
    where we call it.
    
    https://gitlab.gnome.org/GNOME/polari/merge_requests/125

 src/chatView.js        | 2 +-
 src/connections.js     | 2 +-
 src/mainWindow.js      | 2 +-
 src/networksManager.js | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/chatView.js b/src/chatView.js
index 11e3e36..3bcedf1 100644
--- a/src/chatView.js
+++ b/src/chatView.js
@@ -1128,7 +1128,7 @@ var ChatView = GObject.registerClass({
         let tags = [this._lookupTag('status')];
         let groupTag = null;
         if (grouped) {
-            if (this._statusCount.hasOwnProperty(type)) {
+            if (this._statusCount.type !== undefined) {
                 this._statusCount[type]++;
                 this._statusCount.total++;
             }
diff --git a/src/connections.js b/src/connections.js
index 797f8fe..a07a8c7 100644
--- a/src/connections.js
+++ b/src/connections.js
@@ -480,7 +480,7 @@ var ConnectionDetails = GObject.registerClass({
         if (params.use_ssl)
             details['use-ssl'] = GLib.Variant.new('b', params.use_ssl);
 
-        let removed = Object.keys(oldDetails).filter(p => !details.hasOwnProperty(p));
+        let removed = Object.keys(oldDetails).filter(p => details[p] === undefined);
 
         return [details, removed];
     }
diff --git a/src/mainWindow.js b/src/mainWindow.js
index 0dc6142..02aaba9 100644
--- a/src/mainWindow.js
+++ b/src/mainWindow.js
@@ -354,7 +354,7 @@ var MainWindow = GObject.registerClass({
         for (let prop in selectedRoom)
             selectedRoom[prop] = selectedRoom[prop].deep_unpack();
 
-        if (!selectedRoom.hasOwnProperty('account'))
+        if (!selectedRoom.account)
             return;
 
         let roomId = null;
diff --git a/src/networksManager.js b/src/networksManager.js
index b288acb..bfdb0d0 100644
--- a/src/networksManager.js
+++ b/src/networksManager.js
@@ -65,7 +65,7 @@ var NetworksManager = class {
     getNetworkIsFavorite(id) {
         let network = this._lookupNetwork(id);
 
-        if (network.hasOwnProperty('favorite'))
+        if (Object.prototype.hasOwnProperty.call(network, 'favorite'))
             return network['favorite'];
 
         return false;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]