[gnome-shell/wip/appdisplay-leak: 2/2] appDisplay: ensure FolderView gets destroyed with its icon



commit ab927acd24cf8c7efea9406a3300518ae5f0cf86
Author: Ray Strode <rstrode redhat com>
Date:   Mon Jul 15 13:55:20 2019 -0400

    appDisplay: ensure FolderView gets destroyed with its icon
    
    Every FolderIcon has a FolderView associated with it.
    
    When the FolderIcon gets destroyed the folder view should
    get destroyed, too, but currently doesn't.
    
    This commit ties them together explicitly by always destroying
    the folder view when the folder icon is destroyed.

 js/ui/appDisplay.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index c4bac3749..8cb1e0eb8 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1115,7 +1115,7 @@ var FolderIcon = class FolderIcon {
         this.actor.label_actor = this.icon.label;
 
         this.view = new FolderView();
-
+        this.actor.connect('destroy', () => { this.view.actor.destroy(); });
         this.actor.connect('clicked', () => {
             this._ensurePopup();
             this.view.actor.vscroll.adjustment.value = 0;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]