[totem/include-totem-in-desktop-keywords: 3/3] desktop: Include "totem" in .desktop keywords

[Bastien Nocera <hadess src gnome org>]

commit 5af4ee46589a046a5a6cbf1115c4ac5facaf799a
Author: Felipe Borges <felipeborges gnome org>
Date:   Thu May 2 11:41:15 2019 +0200

    desktop: Include "totem" in .desktop keywords
    
    The GNOME Shell search results are forwarded from the results of
    GLib's g_desktop_app_info_search() function, which matches the
    Name, Exec, Keywords, GenericName, X_GNOME_FullName, and Comment
    keys from desktop files[0].
    
    Since Totem is now named "Videos", a query for "totem" would
    match the "Exec" key and present the application in the search
    results as expected. Unfortunately that doesn't happen for Flaptaked
    Totem, which would get its desktop file "Exec" key overwritten to
    something such as Exec=/usr/bin/flatpak run --branch=stable
    --arch=x86_64 --command=totem org.gnome.Totem --new-document
    
    This way, searching for "totem" when only the Flatpaked version
    of it is installed returns no results. Searching for "Videos"
    presents the application as expected.
    
    Its been proposed in GLib to parse the "Exec" key for searches
    but that was rejected[1] because it would imply establishing an
    API which assumes that the command line behavior of Flatpak would
    be stable/never-change.
    
    A fix was proposed in Flatpak directly[2] but it was rejected,
    leaving us with the only option of adding the historical/legacy
    application names to the "Keywords" key in their desktop files.
    
    Many users, such as myself, have the "muscle memory" of search
    for the old application's name, such as "totem", "gedit", "evince".
    Although I agree that the new names should be presented to new
    users and that the old ones shouldn't be visible in UI, it makes
    sense and little effort to support the search for the old names IMO.
    
    [0] https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gdesktopappinfo.c#L378
    [1] https://gitlab.gnome.org/GNOME/glib/issues/1706
    [2] https://github.com/flatpak/flatpak/issues/2749

 data/org.gnome.Totem.desktop.in.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/data/org.gnome.Totem.desktop.in.in b/data/org.gnome.Totem.desktop.in.in
index 61ec6ae7b..74d771f45 100644
--- a/data/org.gnome.Totem.desktop.in.in
+++ b/data/org.gnome.Totem.desktop.in.in
@@ -1,8 +1,8 @@
 [Desktop Entry]
 Name=Videos
 Comment=Play movies
-# Translators: Search terms to find this application. Do NOT translate or localize the semicolons! The list 
MUST also end with a semicolon!
-Keywords=Video;Movie;Film;Clip;Series;Player;DVD;TV;Disc;
+# Translators: Search terms to find this application. Do NOT translate or localize the semicolons! The list 
MUST also end with a semicolon! Do NOT translate or remove the application name from the list! It is used for 
search.
+Keywords=Video;Movie;Film;Clip;Series;Player;DVD;TV;Disc;Totem;
 Exec=totem %U
 # Translators: Do NOT translate or transliterate this text (this is an icon file name)!
 Icon=org.gnome.Totem