[gnome-sudoku] Enable/disable the earmarks only once



commit 118efcaeff24fe612c2a7e1bb20a66260257c4fb
Author: shak-mar <shakmar openmailbox org>
Date:   Tue Jul 9 22:16:26 2019 +0200

    Enable/disable the earmarks only once
    
    As it turns out, calling earmark_picker.set_earmark leads to set_active
    being called on a ToggleButton that has a piece of code listening on its
    "toggled" signal[1] that in turn emits the "earmark_state_changed"
    signal, which in turn is listened to in sudoku-view, where then the
    earmarks were enabled/disabled a second time.
    
    [1]: The ToggleButton sends "toggled" whenever set_active is called,
    see: https://developer.gnome.org/gtk3/stable/GtkToggleButton.html#gtk-toggle-button-set-active

 src/sudoku-view.vala | 4 ----
 1 file changed, 4 deletions(-)
---
diff --git a/src/sudoku-view.vala b/src/sudoku-view.vala
index 68d6517..885b3c5 100644
--- a/src/sudoku-view.vala
+++ b/src/sudoku-view.vala
@@ -293,10 +293,6 @@ private class SudokuCellView : Gtk.DrawingArea
                     create_earmark_picker ();
                 if (earmark_picker.set_earmark (row, col, k_no-1, new_state))
                 {
-                    if (new_state)
-                        game.board.enable_earmark (row, col, k_no);
-                    else
-                        game.board.disable_earmark (row, col, k_no);
                     queue_draw ();
                 }
             }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]