[glib: 2/5] Revert "Work around test failure in gdbus-names"
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib: 2/5] Revert "Work around test failure in gdbus-names"
- Date: Fri, 5 Jul 2019 11:52:52 +0000 (UTC)
commit 1c63d5d539b20e57869a6f73d94256602c2c087d
Author: Matthew Leeds <matthew leeds endlessm com>
Date: Mon Jul 1 15:55:10 2019 -0700
Revert "Work around test failure in gdbus-names"
This reverts commit c37cd19feee3a609fec8909f01df8755052c59ab.
Now that we've reverted the commit "gtestdbus: Properly close server
connections", g_test_dbus_down() no longer returns early and we no
longer need this workaround. Since the gdbus-names test seems to
properly unref its GDBusConnection objects it's not clear to me why it
needed the sleep to succeed. However even at the time the failure wasn't
reproducible according to this comment[1] so it's probably not worth
spending more effort trying to reproduce it now.
[1] https://gitlab.gnome.org/GNOME/glib/issues/787#note_214235
gio/tests/gdbus-names.c | 3 ---
1 file changed, 3 deletions(-)
---
diff --git a/gio/tests/gdbus-names.c b/gio/tests/gdbus-names.c
index 648b54774..4f95b457a 100644
--- a/gio/tests/gdbus-names.c
+++ b/gio/tests/gdbus-names.c
@@ -472,9 +472,6 @@ test_bus_own_name (void)
g_object_unref (c2);
session_bus_down ();
-
- /* See https://bugzilla.gnome.org/show_bug.cgi?id=711807 */
- g_usleep (1000000);
}
/* ---------------------------------------------------------------------------------------------------- */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]