[gnome-font-viewer] font-view: factor out some common code
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-font-viewer] font-view: factor out some common code
- Date: Thu, 4 Jul 2019 23:10:11 +0000 (UTC)
commit 2b09014e9b00de2c8243e6e22622213886a98bb2
Author: Cosimo Cecchi <cosimoc gnome org>
Date: Thu Jul 4 15:59:53 2019 -0700
font-view: factor out some common code
src/font-view.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
---
diff --git a/src/font-view.c b/src/font-view.c
index 2d514b1..b9bac8b 100644
--- a/src/font-view.c
+++ b/src/font-view.c
@@ -557,6 +557,15 @@ font_model_config_changed_cb (FontViewModel *model,
install_button_refresh_appearance (self, NULL);
}
+static void
+font_view_show_install_error (FontViewApplication *self,
+ GError *error)
+{
+ install_button_refresh_appearance (self, error);
+ g_warning ("Install failed: %s", error->message);
+ g_error_free (error);
+}
+
static void
font_install_finished (GObject *source_object,
GAsyncResult *res,
@@ -567,13 +576,8 @@ font_install_finished (GObject *source_object,
g_task_propagate_boolean (G_TASK (res), &err);
- if (err != NULL) {
- /* TODO: show error dialog */
- install_button_refresh_appearance (self, err);
-
- g_debug ("Install failed: %s", err->message);
- g_error_free (err);
- }
+ if (err != NULL)
+ font_view_show_install_error (self, err);
g_clear_object (&self->cancellable);
}
@@ -696,9 +700,7 @@ install_button_clicked_cb (GtkButton *button,
if (!g_file_query_exists (dest_location, NULL)) {
g_file_make_directory_with_parents (dest_location, NULL, &err);
if (err) {
- /* TODO: show error dialog */
- g_warning ("Could not create fonts directory: %s", err->message);
- g_error_free (err);
+ font_view_show_install_error (self, err);
g_object_unref (dest_location);
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]