[gnome-shell/gbsneto/icon-grid-dnd: 15/41] frequentView: Use BaseAppView.addItem() and loadGrid()
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/icon-grid-dnd: 15/41] frequentView: Use BaseAppView.addItem() and loadGrid()
- Date: Thu, 4 Jul 2019 22:27:17 +0000 (UTC)
commit 0f85cf55a443f834fab09060a328e82a40996f3e
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Sat Jun 29 13:15:20 2019 -0300
frequentView: Use BaseAppView.addItem() and loadGrid()
FrequentView is another view that is slightly not unified with how
BaseAppView expects subclasses to load app icons. Instead of using
BaseAppView.addItem() and then calling BaseAppview.loadGrid(), it
adds the app icons directly to the icon grid.
Make FrequentView add icons using BaseAppview.addItem(), and load
the icons using BaseAppView.loadGrid().
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/603
js/ui/appDisplay.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 74560a638..3af641ecf 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -784,8 +784,10 @@ var FrequentView = class FrequentView extends BaseAppView {
continue;
let appIcon = new AppIcon(mostUsed[i], this,
{ isDraggable: favoritesWritable });
- this._grid.addItem(appIcon, -1);
+ this.addItem(appIcon);
}
+
+ this.loadGrid();
}
// Called before allocation to calculate dynamic spacing
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]