[gnome-shell/gbsneto/icon-grid-dnd: 8/9] controlsManager: Don't fade icon grid while dragging
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/icon-grid-dnd: 8/9] controlsManager: Don't fade icon grid while dragging
- Date: Thu, 4 Jul 2019 18:41:25 +0000 (UTC)
commit 9e6029cf585969a12a22cb63e60a513f0f345853
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Wed Jul 3 14:53:09 2019 -0300
controlsManager: Don't fade icon grid while dragging
As pointed out by designers, fading it signals that the
icon grid is not a drop target, when now it actually is.
Remove the fade effect applied to the icon grid when
dragging.https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/603
js/ui/overviewControls.js | 25 -------------------------
1 file changed, 25 deletions(-)
---
diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index e9f81f776..625a23618 100644
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -194,20 +194,6 @@ var SlidingControl = class {
this._updateSlide();
}
- fadeIn() {
- Tweener.addTween(this.actor, { opacity: 255,
- time: SIDE_CONTROLS_ANIMATION_TIME / 2,
- transition: 'easeInQuad'
- });
- }
-
- fadeHalf() {
- Tweener.addTween(this.actor, { opacity: 128,
- time: SIDE_CONTROLS_ANIMATION_TIME / 2,
- transition: 'easeOutQuad'
- });
- }
-
slideIn() {
this._visible = true;
// we will update slideX and the translation from pageEmpty
@@ -423,17 +409,6 @@ var ControlsManager = class {
layout.connect('allocation-changed', this._updateWorkspacesGeometry.bind(this));
Main.overview.connect('showing', this._updateSpacerVisibility.bind(this));
- Main.overview.connect('item-drag-begin', () => {
- let activePage = this.viewSelector.getActivePage();
- if (activePage != ViewSelector.ViewPage.WINDOWS)
- this.viewSelector.fadeHalf();
- });
- Main.overview.connect('item-drag-end', () => {
- this.viewSelector.fadeIn();
- });
- Main.overview.connect('item-drag-cancelled', () => {
- this.viewSelector.fadeIn();
- });
}
_updateWorkspacesGeometry() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]