[gnome-shell/gbsneto/icon-grid-dnd: 15/37] frequentView: Use BaseAppView.addItem() and loadGrid()



commit 0e3be0357e8c892bf0324009c651894ea51b58fa
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Sat Jun 29 13:15:20 2019 -0300

    frequentView: Use BaseAppView.addItem() and loadGrid()
    
    FrequentView is another view that is slightly not unified with how
    BaseAppView expects subclasses to load app icons. Instead of using
    BaseAppView.addItem() and then calling BaseAppview.loadGrid(), it
    adds the app icons directly to the icon grid.
    
    Make FrequentView add icons using BaseAppview.addItem(), and load
    the icons using BaseAppView.loadGrid().
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/603

 js/ui/appDisplay.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 1579d1231..352e058d9 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -784,8 +784,10 @@ var FrequentView = class FrequentView extends BaseAppView {
                 continue;
             let appIcon = new AppIcon(mostUsed[i], this,
                                       { isDraggable: favoritesWritable });
-            this._grid.addItem(appIcon, -1);
+            this.addItem(appIcon);
         }
+
+        this.loadGrid();
     }
 
     // Called before allocation to calculate dynamic spacing


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]