[gnome-shell] cleanup: Remove unneeded escapes in regex
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] cleanup: Remove unneeded escapes in regex
- Date: Mon, 1 Jul 2019 22:31:21 +0000 (UTC)
commit e7d44bb3493e100acbefd54af0c0e82db2947808
Author: Florian Müllner <fmuellner gnome org>
Date: Tue Jan 29 23:44:38 2019 +0100
cleanup: Remove unneeded escapes in regex
. and ) lose their special meaning in character sets, so they don't
need escaping. The same applies to - when it isn't part of a range.
Spotted by eslint.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/607
js/misc/jsParse.js | 4 ++--
js/ui/messageTray.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/js/misc/jsParse.js b/js/misc/jsParse.js
index 2f3f7afff..08ef7d555 100644
--- a/js/misc/jsParse.js
+++ b/js/misc/jsParse.js
@@ -51,7 +51,7 @@ function getCompletions(text, commandHeader, globalCompletionList) {
// if we encounter anything that isn't a letter, '.', ')', or ']',
// we should stop parsing.
function isStopChar(c) {
- return !c.match(/[\w\.\)\]]/);
+ return !c.match(/[\w.)\]]/);
}
// Given the ending position of a quoted string, find where it starts
@@ -121,7 +121,7 @@ function getExpressionOffset(expr, offset) {
return offset + 1;
}
- if (currChar.match(/[\)\]]/)) {
+ if (currChar.match(/[)\]]/)) {
offset = findMatchingBrace(expr, offset);
}
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 4007f1b00..fc54f0d10 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -248,7 +248,7 @@ class NotificationApplicationPolicy extends NotificationPolicy {
_canonicalizeId(id) {
// Keys are restricted to lowercase alphanumeric characters and dash,
// and two dashes cannot be in succession
- return id.toLowerCase().replace(/[^a-z0-9\-]/g, '-').replace(/--+/g, '-');
+ return id.toLowerCase().replace(/[^a-z0-9-]/g, '-').replace(/--+/g, '-');
}
get enable() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]