[gnome-shell] ripples: Remove unreachable return statements
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] ripples: Remove unreachable return statements
- Date: Mon, 1 Jul 2019 21:14:51 +0000 (UTC)
commit 6970f43e666f7f6f091a0829cbfbfb370d9d775e
Author: Florian Müllner <fmuellner gnome org>
Date: Sat Jun 29 14:36:13 2019 +0200
ripples: Remove unreachable return statements
Throwing an exception stops execution of the current function,
so the following return statements are both unnecessary and
unreachable.
Spotted by eslint.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/606
js/ui/ripples.js | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/js/ui/ripples.js b/js/ui/ripples.js
index 37d7362de..96abe181a 100644
--- a/js/ui/ripples.js
+++ b/js/ui/ripples.js
@@ -61,10 +61,8 @@ var Ripples = class Ripples {
}
addTo(stage) {
- if (this._stage !== undefined) {
+ if (this._stage !== undefined)
throw new Error('Ripples already added');
- return;
- }
this._stage = stage;
this._stage.add_actor(this._ripple1);
@@ -73,10 +71,8 @@ var Ripples = class Ripples {
}
playAnimation(x, y) {
- if (this._stage === undefined) {
+ if (this._stage === undefined)
throw new Error('Ripples not added');
- return;
- }
this._x = x;
this._y = y;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]