[shotwell] plugins: Remove facebook publisher

[Jens Georg <jensgeorg src gnome org>]

commit 7b5aeadbeb5a6d2719e439938f8a0613ef3c41de
Author: Jens Georg <mail jensge org>
Date:   Thu Jan 31 15:26:49 2019 +0100

    plugins: Remove facebook publisher
    
    It is broken and cannot be fixed.

 .../shotwell/FacebookPublishingAuthenticator.vala  |  318 -----
 .../shotwell/ShotwellAuthenticatorFactory.vala     |    2 -
 plugins/authenticator/shotwell/meson.build         |    1 -
 .../shotwell-publishing/FacebookPublishing.vala    | 1392 --------------------
 plugins/shotwell-publishing/facebook.png           |  Bin 916 -> 0 bytes
 .../facebook_publishing_options_pane.ui            |  223 ----
 plugins/shotwell-publishing/meson.build            |    1 -
 .../org.gnome.Shotwell.Publishing.gresource.xml    |    2 -
 .../shotwell-publishing/shotwell-publishing.vala   |    6 -
 src/plugins/PublishingInterfaces.vala              |    2 +-
 src/plugins/StandardHostInterface.vala             |    3 -
 src/publishing/Publishing.vala                     |    1 -
 12 files changed, 1 insertion(+), 1950 deletions(-)
---
diff --git a/plugins/authenticator/shotwell/ShotwellAuthenticatorFactory.vala 
b/plugins/authenticator/shotwell/ShotwellAuthenticatorFactory.vala
index 36fb2902..44009f87 100644
--- a/plugins/authenticator/shotwell/ShotwellAuthenticatorFactory.vala
+++ b/plugins/authenticator/shotwell/ShotwellAuthenticatorFactory.vala
@@ -26,8 +26,6 @@ namespace Publishing.Authenticator {
             switch (provider) {
                 case "flickr":
                     return new Shotwell.Flickr.Flickr(host);
-                case "facebook":
-                    return new Shotwell.Facebook.Facebook(host);
                 case "youtube":
                     return new Shotwell.Google.Google("https://gdata.youtube.com/";, _("You are not currently 
logged into YouTube.\n\nYou must have already signed up for a Google account and set it up for use with 
YouTube to continue. You can set up most accounts by using your browser to log into the YouTube site at least 
once."), host);
                 case "tumblr":
diff --git a/plugins/authenticator/shotwell/meson.build b/plugins/authenticator/shotwell/meson.build
index 44042426..b1a6fd2b 100644
--- a/plugins/authenticator/shotwell/meson.build
+++ b/plugins/authenticator/shotwell/meson.build
@@ -1,6 +1,5 @@
 authenticator_shotwell_sources = [
         'ShotwellAuthenticatorFactory.vala',
-        'FacebookPublishingAuthenticator.vala',
         'FlickrPublishingAuthenticator.vala',
         'GoogleAuthenticator.vala',
         'OAuth1Authenticator.vala',
diff --git a/plugins/shotwell-publishing/meson.build b/plugins/shotwell-publishing/meson.build
index eeac1773..a5f9ed8f 100644
--- a/plugins/shotwell-publishing/meson.build
+++ b/plugins/shotwell-publishing/meson.build
@@ -1,6 +1,5 @@
 shotwell_publishing_sources = [
     'shotwell-publishing.vala',
-    'FacebookPublishing.vala',
     'FlickrPublishing.vala',
     'TumblrPublishing.vala',
     'YouTubePublishing.vala',
diff --git a/plugins/shotwell-publishing/org.gnome.Shotwell.Publishing.gresource.xml 
b/plugins/shotwell-publishing/org.gnome.Shotwell.Publishing.gresource.xml
index 436ea9e5..5bcb3b76 100644
--- a/plugins/shotwell-publishing/org.gnome.Shotwell.Publishing.gresource.xml
+++ b/plugins/shotwell-publishing/org.gnome.Shotwell.Publishing.gresource.xml
@@ -1,12 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <gresources>
   <gresource prefix="/org/gnome/Shotwell/Publishing">
-      <file>facebook.png</file>
       <file>piwigo.png</file>
       <file>youtube.png</file>
       <file>tumblr.png</file>
       <file>google-photos.svg</file>
-      <file>facebook_publishing_options_pane.ui</file>
       <file>flickr_publishing_options_pane.ui</file>
       <file>google_photos_publishing_options_pane.ui</file>
       <file>piwigo_authentication_pane.ui</file>
diff --git a/plugins/shotwell-publishing/shotwell-publishing.vala 
b/plugins/shotwell-publishing/shotwell-publishing.vala
index 52c82ec1..896d527d 100644
--- a/plugins/shotwell-publishing/shotwell-publishing.vala
+++ b/plugins/shotwell-publishing/shotwell-publishing.vala
@@ -22,12 +22,6 @@ private class ShotwellPublishingCoreServices : Object, Spit.Module {
         debug("Looking for resources in %s", resource_directory.get_path());
         debug("Found %d authenicators", authenicators.size);
 
-#if HAVE_FACEBOOK
-        if (authenicators.contains("facebook")) {
-            pluggables += new FacebookService(resource_directory);
-        }
-#endif
-
 #if HAVE_GOOGLEPHOTOS
         if (authenicators.contains("google-photos")) {
             pluggables += new Publishing.GooglePhotos.Service(resource_directory);
diff --git a/src/plugins/PublishingInterfaces.vala b/src/plugins/PublishingInterfaces.vala
index 6518142c..99017a73 100644
--- a/src/plugins/PublishingInterfaces.vala
+++ b/src/plugins/PublishingInterfaces.vala
@@ -9,7 +9,7 @@
  *
  * The Shotwell Pluggable Publishing API allows you to write plugins that upload
  * photos and videos to web services. The Shotwell distribution includes publishing
- * support for four core services: Facebook, Flickr, Picasa Web Albums, and YouTube.
+ * support for three core services: Flickr, Google Photos, and YouTube.
  * To enable Shotwell to connect to additional services, developers like you write
  * publishing plugins, dynamically-loadable shared objects that are linked into the
  * Shotwell process at runtime. Publishing plugins are just one of several kinds of
diff --git a/src/plugins/StandardHostInterface.vala b/src/plugins/StandardHostInterface.vala
index d0f3ed4e..ba53a074 100644
--- a/src/plugins/StandardHostInterface.vala
+++ b/src/plugins/StandardHostInterface.vala
@@ -23,9 +23,6 @@ public class StandardHostInterface : Object, Spit.HostInterface {
         // special case: legacy plugins (Web publishers moved into SPIT) have special names
         // new plugins will use their full ID
         switch (id) {
-            case "org.yorba.shotwell.publishing.facebook":
-                return "facebook";
-            
             case "org.yorba.shotwell.publishing.flickr":
                 return "flickr";
                 
diff --git a/src/publishing/Publishing.vala b/src/publishing/Publishing.vala
index 455013c2..5fb80987 100644
--- a/src/publishing/Publishing.vala
+++ b/src/publishing/Publishing.vala
@@ -8,7 +8,6 @@ namespace Publishing {
 
 public void init() throws Error {
     string[] core_ids = new string[0];
-    core_ids += "org.yorba.shotwell.publishing.facebook";
     core_ids += "org.yorba.shotwell.publishing.flickr";
     core_ids += "org.yorba.shotwell.publishing.youtube";
     core_ids += "org.yorba.shotwell.publishing.gnome-photos";