[gnome-shell/wip/fmuellner/minor-bug-fixes: 9/9] iconGrid: Remove unreachable code



commit 09c76937dc3bf5a807e158c2900f770cde84fc8a
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Jan 29 23:00:46 2019 +0100

    iconGrid: Remove unreachable code
    
    Throwing an exception already aborts a function, so there's no need
    for a return statement in that case.
    
    Spotted by eslint.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/375

 js/ui/iconGrid.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/js/ui/iconGrid.js b/js/ui/iconGrid.js
index cd54d50a3..452dc0c96 100644
--- a/js/ui/iconGrid.js
+++ b/js/ui/iconGrid.js
@@ -906,10 +906,8 @@ var PaginatedIconGrid = GObject.registerClass({
     getItemPage(item) {
         let children = this._getVisibleChildren();
         let index = children.indexOf(item);
-        if (index == -1) {
+        if (index == -1)
             throw new Error('Item not found.');
-            return 0;
-        }
         return Math.floor(index / this._childrenPerPage);
     }
 
@@ -924,10 +922,9 @@ var PaginatedIconGrid = GObject.registerClass({
     openExtraSpace(sourceItem, side, nRows) {
         let children = this._getVisibleChildren();
         let index = children.indexOf(sourceItem.actor);
-        if (index == -1) {
+        if (index == -1)
             throw new Error('Item not found.');
-            return;
-        }
+
         let pageIndex = Math.floor(index / this._childrenPerPage);
         let pageOffset = pageIndex * this._childrenPerPage;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]