[mutter/wip/carlosg/clip-me-harder: 3/5] compositor: Fix check to clip beneath the window



commit f1ac8c3ddc71930e6a9103c75b85e4c940091b8d
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sun Jan 27 15:43:35 2019 +0100

    compositor: Fix check to clip beneath the window
    
    We want to clip it away if 1) The window is fully opaque or
    2) If it's translucent but has a frame (as explained in the comment
    above). The code didn't quite match and we were only applying it on
    case #2.
    
    Case #1 is far more common, and saves us from pushing some drawing
    that we know will be covered in the end.

 src/compositor/meta-window-actor.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/compositor/meta-window-actor.c b/src/compositor/meta-window-actor.c
index ebfe94c22..70fabfb7d 100644
--- a/src/compositor/meta-window-actor.c
+++ b/src/compositor/meta-window-actor.c
@@ -647,7 +647,10 @@ clip_shadow_under_window (MetaWindowActor *self)
   MetaWindowActorPrivate *priv =
     meta_window_actor_get_instance_private (self);
 
-  return is_non_opaque (self) && priv->window->frame;
+  if (priv->window->frame)
+    return TRUE;
+
+  return !is_non_opaque (self);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]