[gtk/wip/jimmac/adwaita-3-32: 36/38] Adwaita: Fix wrong icon position in some buttons

[Jakub Steiner <jimmac src gnome org>]

commit d82edf0c915d103d3426008618d6c544b7f7d9f9
Author: nana-4 <hnmaigo gmail com>
Date:   Fri Jan 25 21:02:47 2019 +0900

    Adwaita: Fix wrong icon position in some buttons
    
    This commit reverts min-width sizes and changes horizontal padding instead in
    order to avoid off-centered button icons.
    
    Fixes #1621

 gtk/theme/Adwaita/_common.scss           | 14 +++++++-------
 gtk/theme/Adwaita/gtk-contained-dark.css |  8 ++++----
 gtk/theme/Adwaita/gtk-contained.css      |  8 ++++----
 3 files changed, 15 insertions(+), 15 deletions(-)
---
diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index fa19fbcb62..43bfac2e14 100644
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -522,8 +522,8 @@ button {
   @at-root %button_basic, & {
 
     min-height: 24px;
-    min-width: 18px;
-    padding: 4px 8px;
+    min-width: 16px;
+    padding: 4px 9px;
     border: 1px solid;
     border-radius: $button_radius;
     transition: $button_transition;
@@ -587,9 +587,9 @@ button {
     }
 
     &.image-button {
-      min-width: 26px;
-      padding-left: 4px;
-      padding-right: 4px;
+      min-width: 24px;
+      padding-left: 5px;
+      padding-right: 5px;
     }
 
     &.text-button {
@@ -630,10 +630,10 @@ button {
 
   // big standalone buttons like in Documents pager
   &.osd {
-    min-width: 26px;
+    min-width: 24px;
     min-height: 32px;
 
-    &.image-button { min-width: 34px; }
+    &.image-button { min-width: 32px; }
 
     color: $osd_fg_color;
     border-radius: 5px;
diff --git a/gtk/theme/Adwaita/gtk-contained-dark.css b/gtk/theme/Adwaita/gtk-contained-dark.css
index caf042b2ee..ee900c952c 100644
--- a/gtk/theme/Adwaita/gtk-contained-dark.css
+++ b/gtk/theme/Adwaita/gtk-contained-dark.css
@@ -184,7 +184,7 @@ treeview entry.flat:focus, treeview entry:focus { border-color: #15539e; }
 @keyframes needs_attention { from { background-image: -gtk-gradient(radial, center center, 0, center center, 
0.01, to(#1f76e1), to(transparent)); }
   to { background-image: -gtk-gradient(radial, center center, 0, center center, 0.5, to(#15539e), 
to(transparent)); } }
 
-notebook > header > tabs > arrow, button.titlebutton, button { min-height: 24px; min-width: 18px; padding: 
4px 8px; border: 1px solid; border-radius: 5px; transition: all 200ms cubic-bezier(0.25, 0.46, 0.45, 0.94); 
color: #eeeeec; outline-color: rgba(238, 238, 236, 0.3); border-color: #1b1b1b; border-bottom-color: #070707; 
background-image: linear-gradient(to top, #323232 2px, #353535); text-shadow: 0 -1px rgba(0, 0, 0, 0.834353); 
-gtk-icon-shadow: 0 -1px rgba(0, 0, 0, 0.834353); box-shadow: inset 0 1px rgba(255, 255, 255, 0.02), 0 1px 
2px rgba(0, 0, 0, 0.07); }
+notebook > header > tabs > arrow, button.titlebutton, button { min-height: 24px; min-width: 16px; padding: 
4px 9px; border: 1px solid; border-radius: 5px; transition: all 200ms cubic-bezier(0.25, 0.46, 0.45, 0.94); 
color: #eeeeec; outline-color: rgba(238, 238, 236, 0.3); border-color: #1b1b1b; border-bottom-color: #070707; 
background-image: linear-gradient(to top, #323232 2px, #353535); text-shadow: 0 -1px rgba(0, 0, 0, 0.834353); 
-gtk-icon-shadow: 0 -1px rgba(0, 0, 0, 0.834353); box-shadow: inset 0 1px rgba(255, 255, 255, 0.02), 0 1px 
2px rgba(0, 0, 0, 0.07); }
 
 notebook > header > tabs > arrow, button.sidebar-button, button.titlebutton, button.flat { border-color: 
transparent; background-color: transparent; background-image: none; box-shadow: inset 0 1px rgba(255, 255, 
255, 0); text-shadow: none; -gtk-icon-shadow: none; transition: none; }
 
@@ -222,7 +222,7 @@ notebook > header > tabs > arrow:disabled:active, button.titlebutton:disabled:ac
 
 notebook > header > tabs > arrow:disabled:active label, button.titlebutton:disabled:active label, notebook > 
header > tabs > arrow:disabled:active, button.titlebutton:disabled:active, notebook > header > tabs > 
arrow:disabled:checked label, button.titlebutton:disabled:checked label, notebook > header > tabs > 
arrow:disabled:checked, button.titlebutton:disabled:checked, button:disabled:active label, 
button:disabled:active, button:disabled:checked label, button:disabled:checked { color: #919190; }
 
-notebook > header > tabs > arrow.image-button, button.image-button.titlebutton, button.image-button { 
min-width: 26px; padding-left: 4px; padding-right: 4px; }
+notebook > header > tabs > arrow.image-button, button.image-button.titlebutton, button.image-button { 
min-width: 24px; padding-left: 5px; padding-right: 5px; }
 
 notebook > header > tabs > arrow.text-button, button.text-button.titlebutton, button.text-button { 
padding-left: 16px; padding-right: 16px; }
 
@@ -236,9 +236,9 @@ row:selected button.sidebar-button:not(:active):not(:checked):not(:hover):not(di
 
 row:selected button.sidebar-button:not(:active):not(:checked):not(:hover):not(disabled):backdrop, 
row:selected button.flat:not(:active):not(:checked):not(:hover):not(disabled):backdrop { color: #919190; }
 
-button.osd { min-width: 26px; min-height: 32px; color: #eeeeec; border-radius: 5px; color: #eeeeec; 
border-color: rgba(0, 0, 0, 0.7); background-color: transparent; background-image: image(rgba(36, 33, 42, 
0.7)); background-clip: padding-box; box-shadow: inset 0 1px rgba(255, 255, 255, 0.1); text-shadow: 0 1px 
black; -gtk-icon-shadow: 0 1px black; outline-color: rgba(238, 238, 236, 0.3); border: none; box-shadow: 
none; }
+button.osd { min-width: 24px; min-height: 32px; color: #eeeeec; border-radius: 5px; color: #eeeeec; 
border-color: rgba(0, 0, 0, 0.7); background-color: transparent; background-image: image(rgba(36, 33, 42, 
0.7)); background-clip: padding-box; box-shadow: inset 0 1px rgba(255, 255, 255, 0.1); text-shadow: 0 1px 
black; -gtk-icon-shadow: 0 1px black; outline-color: rgba(238, 238, 236, 0.3); border: none; box-shadow: 
none; }
 
-button.osd.image-button { min-width: 34px; }
+button.osd.image-button { min-width: 32px; }
 
 button.osd:hover { color: white; border-color: rgba(0, 0, 0, 0.7); background-color: transparent; 
background-image: image(rgba(66, 61, 76, 0.7)); background-clip: padding-box; box-shadow: inset 0 1px 
rgba(255, 255, 255, 0.1); text-shadow: 0 1px black; -gtk-icon-shadow: 0 1px black; outline-color: rgba(238, 
238, 236, 0.3); border: none; box-shadow: none; }
 
diff --git a/gtk/theme/Adwaita/gtk-contained.css b/gtk/theme/Adwaita/gtk-contained.css
index f34038aaba..bc760bd2c9 100644
--- a/gtk/theme/Adwaita/gtk-contained.css
+++ b/gtk/theme/Adwaita/gtk-contained.css
@@ -184,7 +184,7 @@ treeview entry.flat:focus, treeview entry:focus { border-color: #3584e4; }
 @keyframes needs_attention { from { background-image: -gtk-gradient(radial, center center, 0, center center, 
0.01, to(#3584e4), to(transparent)); }
   to { background-image: -gtk-gradient(radial, center center, 0, center center, 0.5, to(#3584e4), 
to(transparent)); } }
 
-notebook > header > tabs > arrow, button.titlebutton, button { min-height: 24px; min-width: 18px; padding: 
4px 8px; border: 1px solid; border-radius: 5px; transition: all 200ms cubic-bezier(0.25, 0.46, 0.45, 0.94); 
color: #2e3436; outline-color: rgba(46, 52, 54, 0.3); border-color: #cdc7c2; border-bottom-color: #bfb8b1; 
background-image: linear-gradient(to top, #edebe9 2px, #f6f5f4); text-shadow: 0 1px rgba(255, 255, 255, 
0.769231); -gtk-icon-shadow: 0 1px rgba(255, 255, 255, 0.769231); box-shadow: inset 0 1px white, 0 1px 2px 
rgba(0, 0, 0, 0.07); }
+notebook > header > tabs > arrow, button.titlebutton, button { min-height: 24px; min-width: 16px; padding: 
4px 9px; border: 1px solid; border-radius: 5px; transition: all 200ms cubic-bezier(0.25, 0.46, 0.45, 0.94); 
color: #2e3436; outline-color: rgba(46, 52, 54, 0.3); border-color: #cdc7c2; border-bottom-color: #bfb8b1; 
background-image: linear-gradient(to top, #edebe9 2px, #f6f5f4); text-shadow: 0 1px rgba(255, 255, 255, 
0.769231); -gtk-icon-shadow: 0 1px rgba(255, 255, 255, 0.769231); box-shadow: inset 0 1px white, 0 1px 2px 
rgba(0, 0, 0, 0.07); }
 
 notebook > header > tabs > arrow, button.sidebar-button, button.titlebutton, button.flat { border-color: 
transparent; background-color: transparent; background-image: none; box-shadow: inset 0 1px rgba(255, 255, 
255, 0); text-shadow: none; -gtk-icon-shadow: none; transition: none; }
 
@@ -222,7 +222,7 @@ notebook > header > tabs > arrow:disabled:active, button.titlebutton:disabled:ac
 
 notebook > header > tabs > arrow:disabled:active label, button.titlebutton:disabled:active label, notebook > 
header > tabs > arrow:disabled:active, button.titlebutton:disabled:active, notebook > header > tabs > 
arrow:disabled:checked label, button.titlebutton:disabled:checked label, notebook > header > tabs > 
arrow:disabled:checked, button.titlebutton:disabled:checked, button:disabled:active label, 
button:disabled:active, button:disabled:checked label, button:disabled:checked { color: #929595; }
 
-notebook > header > tabs > arrow.image-button, button.image-button.titlebutton, button.image-button { 
min-width: 26px; padding-left: 4px; padding-right: 4px; }
+notebook > header > tabs > arrow.image-button, button.image-button.titlebutton, button.image-button { 
min-width: 24px; padding-left: 5px; padding-right: 5px; }
 
 notebook > header > tabs > arrow.text-button, button.text-button.titlebutton, button.text-button { 
padding-left: 16px; padding-right: 16px; }
 
@@ -238,9 +238,9 @@ row:selected button.sidebar-button:not(:active):not(:checked):not(:hover):not(di
 
 row:selected button.sidebar-button:not(:active):not(:checked):not(:hover):not(disabled):backdrop, 
row:selected button.flat:not(:active):not(:checked):not(:hover):not(disabled):backdrop { color: #fcfcfc; }
 
-button.osd { min-width: 26px; min-height: 32px; color: #eeeeec; border-radius: 5px; color: #eeeeec; 
border-color: rgba(0, 0, 0, 0.7); background-color: transparent; background-image: image(rgba(36, 33, 42, 
0.7)); background-clip: padding-box; box-shadow: inset 0 1px rgba(255, 255, 255, 0.1); text-shadow: 0 1px 
black; -gtk-icon-shadow: 0 1px black; outline-color: rgba(238, 238, 236, 0.3); border: none; box-shadow: 
none; }
+button.osd { min-width: 24px; min-height: 32px; color: #eeeeec; border-radius: 5px; color: #eeeeec; 
border-color: rgba(0, 0, 0, 0.7); background-color: transparent; background-image: image(rgba(36, 33, 42, 
0.7)); background-clip: padding-box; box-shadow: inset 0 1px rgba(255, 255, 255, 0.1); text-shadow: 0 1px 
black; -gtk-icon-shadow: 0 1px black; outline-color: rgba(238, 238, 236, 0.3); border: none; box-shadow: 
none; }
 
-button.osd.image-button { min-width: 34px; }
+button.osd.image-button { min-width: 32px; }
 
 button.osd:hover { color: white; border-color: rgba(0, 0, 0, 0.7); background-color: transparent; 
background-image: image(rgba(66, 61, 76, 0.7)); background-clip: padding-box; box-shadow: inset 0 1px 
rgba(255, 255, 255, 0.1); text-shadow: 0 1px black; -gtk-icon-shadow: 0 1px black; outline-color: rgba(238, 
238, 236, 0.3); border: none; box-shadow: none; }