[gnome-software] rpm-ostree: trivial: Correctly return FALSE on error



commit 364ffbb49b218dd1957cb931a97b7d6a0ef7a7f0
Author: Kalev Lember <klember redhat com>
Date:   Sat Jan 26 19:40:03 2019 +0100

    rpm-ostree: trivial: Correctly return FALSE on error

 plugins/rpm-ostree/gs-plugin-rpm-ostree.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
index f57de5fe..554670f6 100644
--- a/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
+++ b/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
@@ -614,7 +614,10 @@ gs_plugin_add_updates (GsPlugin *plugin,
        g_auto(GVariantDict) cached_update_dict;
 
        /* ensure D-Bus properties are updated before reading them */
-       gs_rpmostree_sysroot_call_reload_sync (priv->sysroot_proxy, cancellable, error);
+       if (!gs_rpmostree_sysroot_call_reload_sync (priv->sysroot_proxy, cancellable, error)) {
+               gs_utils_error_convert_gio (error);
+               return FALSE;
+       }
 
        cached_update = gs_rpmostree_os_dup_cached_update (priv->os_proxy);
        g_variant_dict_init (&cached_update_dict, cached_update);
@@ -1013,7 +1016,10 @@ gs_plugin_refine (GsPlugin *plugin,
        g_autofree gchar *checksum = NULL;
 
        /* ensure D-Bus properties are updated before reading them */
-       gs_rpmostree_sysroot_call_reload_sync (priv->sysroot_proxy, cancellable, error);
+       if (!gs_rpmostree_sysroot_call_reload_sync (priv->sysroot_proxy, cancellable, error)) {
+               gs_utils_error_convert_gio (error);
+               return FALSE;
+       }
 
        booted_deployment = gs_rpmostree_os_dup_booted_deployment (priv->os_proxy);
        g_assert (g_variant_lookup (booted_deployment,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]