[dconf-editor] Remove some unused methods.
- From: Arnaud B. <arnaudb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [dconf-editor] Remove some unused methods.
- Date: Sun, 20 Jan 2019 10:36:16 +0000 (UTC)
commit 14e05556f5ae2a68c68a3bb3ac693155b144d3a7
Author: Arnaud Bonatti <arnaud bonatti gmail com>
Date: Sun Jan 20 04:40:30 2019 +0100
Remove some unused methods.
These overrides were completely useless.
editor/base-headerbar.vala | 4 +---
editor/bookmarks-headerbar.vala | 8 ++++----
editor/browser-headerbar.vala | 14 --------------
3 files changed, 5 insertions(+), 21 deletions(-)
---
diff --git a/editor/base-headerbar.vala b/editor/base-headerbar.vala
index f92550b..68f18d2 100644
--- a/editor/base-headerbar.vala
+++ b/editor/base-headerbar.vala
@@ -304,8 +304,6 @@ private class BaseHeaderBar : NightTimeAwareHeaderBar, AdaptativeWidget
internal virtual bool has_popover ()
{
- if (info_button.active)
- return true;
- return false;
+ return info_button.active;
}
}
diff --git a/editor/bookmarks-headerbar.vala b/editor/bookmarks-headerbar.vala
index 0475768..54848a5 100644
--- a/editor/bookmarks-headerbar.vala
+++ b/editor/bookmarks-headerbar.vala
@@ -272,18 +272,18 @@ private abstract class BookmarksHeaderBar : BrowserHeaderBar, AdaptativeWidget
* * keyboard calls
\*/
- internal override bool next_match ()
+ internal virtual bool next_match ()
{
if (bookmarks_button.active)
return bookmarks_button.next_match ();
- return base.next_match (); // false
+ return false;
}
- internal override bool previous_match ()
+ internal virtual bool previous_match ()
{
if (bookmarks_button.active)
return bookmarks_button.previous_match ();
- return base.previous_match (); // false
+ return false;
}
internal bool handle_copy_text (out string copy_text)
diff --git a/editor/browser-headerbar.vala b/editor/browser-headerbar.vala
index c7df05c..d0cccee 100644
--- a/editor/browser-headerbar.vala
+++ b/editor/browser-headerbar.vala
@@ -170,20 +170,6 @@ private abstract class BrowserHeaderBar : BaseHeaderBar, AdaptativeWidget
true); /* show quit_button_stack */
}
- /*\
- * * keyboard calls
- \*/
-
- internal virtual bool next_match ()
- {
- return false;
- }
-
- internal virtual bool previous_match ()
- {
- return false;
- }
-
/*\
* * popovers methods
\*/
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]