[gnome-builder] greeter: tweak project creation menus

[Christian Hergert <chergert src gnome org>]

commit fe701115d59c5f767eeaf8169eb8cbac29f2bb37
Author: Christian Hergert <chergert redhat com>
Date:   Fri Jan 18 17:17:36 2019 -0800

    greeter: tweak project creation menus
    
    Fixes #766

 src/libide/greeter/ide-greeter-buttons-section.c    |  2 +-
 src/plugins/create-project/gtk/menus.ui             |  6 +++---
 src/plugins/greeter/gbp-greeter-application-addin.c |  2 +-
 src/plugins/greeter/gtk/menus.ui                    | 21 +++------------------
 4 files changed, 8 insertions(+), 23 deletions(-)
---
diff --git a/src/libide/greeter/ide-greeter-buttons-section.c 
b/src/libide/greeter/ide-greeter-buttons-section.c
index 4f7c66663..4778024b3 100644
--- a/src/libide/greeter/ide-greeter-buttons-section.c
+++ b/src/libide/greeter/ide-greeter-buttons-section.c
@@ -89,7 +89,7 @@ ide_greeter_buttons_section_init (IdeGreeterButtonsSection *self)
   ide_greeter_buttons_section_add_button (self,
                                           100,
                                           g_object_new (GTK_TYPE_BUTTON,
-                                                        "label", _("Clone…"),
+                                                        "label", _("Clone Repository…"),
                                                         "visible", TRUE,
                                                         "action-name", "win.surface",
                                                         "action-target", g_variant_new_string ("clone"),
diff --git a/src/plugins/create-project/gtk/menus.ui b/src/plugins/create-project/gtk/menus.ui
index 39b891e3f..65d552c98 100644
--- a/src/plugins/create-project/gtk/menus.ui
+++ b/src/plugins/create-project/gtk/menus.ui
@@ -4,7 +4,7 @@
     <section id="ide-greeter-workspace-menu-projects">
       <item>
         <attribute name="id">ide-greeter-workspace-menu-new</attribute>
-        <attribute name="label" translatable="yes">_New Project</attribute>
+        <attribute name="label" translatable="yes">_Start New Project…</attribute>
         <attribute name="action">win.surface</attribute>
         <attribute name="target" type="s">'create-project'</attribute>
         <attribute name="before">ide-greeter-workspace-menu-open</attribute>
@@ -15,7 +15,7 @@
     <section id="ide-primary-workspace-menu-projects-section">
       <item>
         <attribute name="id">ide-primary-workspace-menu-new</attribute>
-        <attribute name="label" translatable="yes">_New Project</attribute>
+        <attribute name="label" translatable="yes">_Start New Project…</attribute>
         <attribute name="action">app.present-greeter-with-surface</attribute>
         <attribute name="target" type="s">'create-project'</attribute>
         <attribute name="before">ide-primary-workspace-menu-open</attribute>
@@ -26,7 +26,7 @@
     <section id="ide-editor-workspace-menu-projects-section">
       <item>
         <attribute name="id">ide-editor-workspace-menu-new</attribute>
-        <attribute name="label" translatable="yes">_New Project</attribute>
+        <attribute name="label" translatable="yes">_Start New Project…</attribute>
         <attribute name="action">app.present-greeter-with-surface</attribute>
         <attribute name="target" type="s">'create-project'</attribute>
         <attribute name="before">ide-editor-workspace-menu-open</attribute>
diff --git a/src/plugins/greeter/gbp-greeter-application-addin.c 
b/src/plugins/greeter/gbp-greeter-application-addin.c
index f999879a3..12e20f8d5 100644
--- a/src/plugins/greeter/gbp-greeter-application-addin.c
+++ b/src/plugins/greeter/gbp-greeter-application-addin.c
@@ -55,7 +55,7 @@ present_greeter_with_surface (GSimpleAction *action,
   workspace = ide_greeter_workspace_new (self->application);
   ide_workbench_add_workspace (workbench, IDE_WORKSPACE (workspace));
 
-  if (param != NULL && (name = g_variant_get_string (param, NULL)))
+  if (param != NULL && (name = g_variant_get_string (param, NULL)) && !ide_str_empty0 (name))
     ide_workspace_set_visible_surface_name (IDE_WORKSPACE (workspace), name);
 
   ide_workbench_focus_workspace (workbench, IDE_WORKSPACE (workspace));
diff --git a/src/plugins/greeter/gtk/menus.ui b/src/plugins/greeter/gtk/menus.ui
index ff260345b..e702ccfda 100644
--- a/src/plugins/greeter/gtk/menus.ui
+++ b/src/plugins/greeter/gtk/menus.ui
@@ -2,14 +2,9 @@
 <interface>
   <menu id="ide-greeter-workspace-menu">
     <section id="ide-greeter-workspace-menu-projects">
-      <item>
-        <attribute name="id">ide-greeter-workspace-menu-open</attribute>
-        <attribute name="label" translatable="yes">_Open Project</attribute>
-        <attribute name="action">win.open</attribute>
-      </item>
       <item>
         <attribute name="id">ide-greeter-workspace-menu-clone</attribute>
-        <attribute name="label" translatable="yes">_Clone Repository</attribute>
+        <attribute name="label" translatable="yes">_Clone Repository…</attribute>
         <attribute name="action">win.surface</attribute>
         <attribute name="target" type="s">'clone'</attribute>
       </item>
@@ -66,14 +61,9 @@
   </menu>
   <menu id="ide-primary-workspace-menu">
     <section id="ide-primary-workspace-menu-projects-section">
-      <item>
-        <attribute name="id">ide-primary-workspace-menu-open</attribute>
-        <attribute name="label" translatable="yes">_Open Project</attribute>
-        <attribute name="action">app.open-project</attribute>
-      </item>
       <item>
         <attribute name="id">ide-primary-workspace-menu-clone</attribute>
-        <attribute name="label" translatable="yes">_Clone Repository</attribute>
+        <attribute name="label" translatable="yes">_Clone Repository…</attribute>
         <attribute name="action">app.present-greeter-with-surface</attribute>
         <attribute name="target" type="s">'clone'</attribute>
       </item>
@@ -81,14 +71,9 @@
   </menu>
   <menu id="ide-editor-workspace-menu">
     <section id="ide-editor-workspace-menu-projects-section">
-      <item>
-        <attribute name="id">ide-editor-workspace-menu-open</attribute>
-        <attribute name="label" translatable="yes">_Open Project</attribute>
-        <attribute name="action">app.open-project</attribute>
-      </item>
       <item>
         <attribute name="id">ide-editor-workspace-menu-clone</attribute>
-        <attribute name="label" translatable="yes">_Clone Repository</attribute>
+        <attribute name="label" translatable="yes">_Clone Repository…</attribute>
         <attribute name="action">app.present-greeter-with-surface</attribute>
         <attribute name="target" type="s">'clone'</attribute>
       </item>