[epiphany/mcatanzaro/file-helpers-test: 2/2] Make file-helpers-test not massacre /tmp and reenable
- From: Jan-Michael Brummer <jbrummer src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/file-helpers-test: 2/2] Make file-helpers-test not massacre /tmp and reenable
- Date: Wed, 9 Jan 2019 13:24:53 +0000 (UTC)
commit a819ae735a949bf140fa9ed67c43887d6e65a8e4
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Tue Jan 8 18:54:52 2019 -0600
Make file-helpers-test not massacre /tmp and reenable
It's not very friendly for this test to delete everything it has access
to under /tmp. Not at all. Asides from the fact that this causes other
unrelated tests to fail when their /tmp dirs are deleted out from under
them, it's going to cause all sorts of problems for unrelated
applications as well. No no no no no.
Fixes #617
tests/ephy-file-helpers-test.c | 1 -
tests/meson.build | 16 ++++++++--------
2 files changed, 8 insertions(+), 9 deletions(-)
---
diff --git a/tests/ephy-file-helpers-test.c b/tests/ephy-file-helpers-test.c
index 8164cb1b3..389ae1cf4 100644
--- a/tests/ephy-file-helpers-test.c
+++ b/tests/ephy-file-helpers-test.c
@@ -165,7 +165,6 @@ typedef struct {
static const DirTest dir_tests[] =
{
- { "/tmp", TRUE, FALSE, FALSE },
{ "/tmp/ephy-test-dir", FALSE, TRUE, TRUE },
/* Unreadable */
{ "/root/ephy-test-dir", FALSE, FALSE, FALSE },
diff --git a/tests/meson.build b/tests/meson.build
index 45962b0e3..6294f4e92 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -55,14 +55,14 @@ if get_option('unit_tests')
env: envs
)
- #file_helpers_test = executable('test-ephy-file-helpers',
- # 'ephy-file-helpers-test.c',
- # dependencies: ephymain_dep
- #)
- #test('File helpers test',
- # file_helpers_test,
- # env: envs
- #)
+ file_helpers_test = executable('test-ephy-file-helpers',
+ 'ephy-file-helpers-test.c',
+ dependencies: ephymain_dep
+ )
+ test('File helpers test',
+ file_helpers_test,
+ env: envs
+ )
gsb_service_test = executable('test-ephy-gsb-service',
'ephy-gsb-service-test.c',
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]