[gbrainy/reproducible] Remove definition and usage of gbrainy's build time.



commit d4fed6973366cc2f6427c2c8fa6138cd60b601a9
Author: Jordi Mallach <jordi mallach net>
Date:   Wed Jan 9 13:02:53 2019 +0100

    Remove definition and usage of gbrainy's build time.
    
    Knowing when the binary was built adds zero useful information to end
    users, but it makes it difficult to build byte for byte identical binaries,
    which are useful for auditing in scopes like the one presented by the
    Reproducible Builds project.
    
    https://reproducible-builds.org/

 configure.ac                         | 3 ---
 src/Clients/Classical/CommandLine.cs | 4 +---
 src/Clients/Classical/Defines.cs.in  | 1 -
 tools/Defines.cs.in                  | 1 -
 tools/GamesStatistics.cs             | 2 +-
 5 files changed, 2 insertions(+), 9 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 33222c0..707f111 100644
--- a/configure.ac
+++ b/configure.ac
@@ -160,9 +160,6 @@ fi
 
 dnl --- Assembly information
 
-BUILD_TIME=`date +"%F %T %Z"`
-AC_SUBST(BUILD_TIME)
-
 COPYRIGHT="(c) 2007-2018 Jordi Mas i Hernandez"
 AC_SUBST(COPYRIGHT)
 
diff --git a/src/Clients/Classical/CommandLine.cs b/src/Clients/Classical/CommandLine.cs
index 8780c53..f2a88ad 100644
--- a/src/Clients/Classical/CommandLine.cs
+++ b/src/Clients/Classical/CommandLine.cs
@@ -103,9 +103,7 @@ namespace gbrainy.Clients.Classical
 
                public static void Version ()
                {
-                       Console.WriteLine ("gbrainy " + Defines.VERSION + " " +
-                               // Translators: {0} is a date
-                               String.Format (Catalog.GetString ("(built on {0})"), Defines.BUILD_TIME));
+                       Console.WriteLine ("gbrainy " + Defines.VERSION);
                }
 
                void GameList ()
diff --git a/src/Clients/Classical/Defines.cs.in b/src/Clients/Classical/Defines.cs.in
index 4b3f7bc..6c2f0cb 100644
--- a/src/Clients/Classical/Defines.cs.in
+++ b/src/Clients/Classical/Defines.cs.in
@@ -25,7 +25,6 @@ namespace gbrainy.Clients.Classical
                public const string GNOME_LOCALE_DIR = "@prefix@/share/locale";
                public const string DATA_DIR = "@prefix@/share/games/gbrainy/";
                public const string COPYRIGHT = "@COPYRIGHT@";
-               public const string BUILD_TIME = "@BUILD_TIME@";
 
                public const string VERBAL_ANALOGIES = "verbal_analogies.xml";
                public const string GAME_ASSEMBLY = "gbrainy.Games.dll";
diff --git a/tools/Defines.cs.in b/tools/Defines.cs.in
index 0682a13..42c4f48 100644
--- a/tools/Defines.cs.in
+++ b/tools/Defines.cs.in
@@ -22,7 +22,6 @@ public static class Defines
        public const string VERSION = "@VERSION@";
         public const string GNOME_LOCALE_DIR = "@prefix@/share/locale";
        public const string DATA_DIR = "@prefix@/share/games/gbrainy/";
-       public const string BUILD_TIME = "@BUILD_TIME@";
 
        public const string VERBAL_ANALOGIES = "verbal_analogies.xml";
        public const string GAME_ASSEMBLY = "gbrainy.Games.dll";
diff --git a/tools/GamesStatistics.cs b/tools/GamesStatistics.cs
index 4c4185f..81c0684 100644
--- a/tools/GamesStatistics.cs
+++ b/tools/GamesStatistics.cs
@@ -125,7 +125,7 @@ public class GamesStatistics
                GameSession session = new GameSession (translations);
                GameManagerPreload (session.GameManager);
 
-               Console.WriteLine ("gbrainy {0} (built on {1})", Defines.VERSION, Defines.BUILD_TIME);
+               Console.WriteLine ("gbrainy {0}", Defines.VERSION);
                Console.WriteLine (session.GameManager.GetGamesSummary (translations));
                Console.WriteLine ("");
                GetStatistics (session.GameManager, translations);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]