[gtk] revealer: Handle child-visible properly



commit b6d8d3975edc29cb5488990d0a39e3d2c4790d89
Author: Benjamin Otte <otte redhat com>
Date:   Tue Jan 8 01:29:41 2019 +0100

    revealer: Handle child-visible properly
    
    The target position is irrelevant for determining if the child should be
    visible. When the current position is 0, it needs to be hidden, period.
    
    Fixes #1355

 gtk/gtkrevealer.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
---
diff --git a/gtk/gtkrevealer.c b/gtk/gtkrevealer.c
index d1245d22fb..508c7d2127 100644
--- a/gtk/gtkrevealer.c
+++ b/gtk/gtkrevealer.c
@@ -390,12 +390,7 @@ gtk_revealer_set_position (GtkRevealer *revealer,
 
   priv->current_pos = pos;
 
-  /* We check target_pos here too, because we want to ensure we set
-   * child_visible immediately when starting a reveal operation
-   * otherwise the child widgets will not be properly realized
-   * after the reveal returns.
-   */
-  new_visible = priv->current_pos != 0.0 || priv->target_pos != 0.0;
+  new_visible = priv->current_pos != 0.0;
 
   child = gtk_bin_get_child (GTK_BIN (revealer));
   if (child != NULL &&


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]