[gtk/wip/dboles/spinbutton-button-backdrop-disabled-3: 1/2] Adwaita: Fix bg of backdrop:disabled spinbutton +-



commit 6eb1be27f7b495bacf2d671f5bd8ede5fce45d51
Author: Daniel Boles <dboles src gmail com>
Date:   Sun Jan 6 19:18:47 2019 +0000

    Adwaita: Fix bg of backdrop:disabled spinbutton +-
    
    The +/- buttons are meant to be transparent, showing the base_color,
    but when backdropped they were picking up background-image from the base
    button, meaning they suddenly became more like theme_bg_color instead,
    and jumped out of the spinbutton when in backdrop unlike the rest of it.
    This looks strange and achieves nothing (especially not indicating that
    they are disabled, which is already served fine by their dim fg colour).
    
    Fix this by explicitly saying we don't want any background-image there.

 gtk/theme/Adwaita/_common.scss           | 1 +
 gtk/theme/Adwaita/gtk-contained-dark.css | 2 +-
 gtk/theme/Adwaita/gtk-contained.css      | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index 4072e44683..737321a961 100644
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -1216,6 +1216,7 @@ spinbutton {
       &:backdrop:disabled {
         color: transparentize($backdrop_insensitive_color,0.7);
         background-color: transparent;
+        background-image: none;
         border-style: none none none solid; // It is needed or it gets overridden
 
         &:dir(rtl) { border-style: none solid none none; }
diff --git a/gtk/theme/Adwaita/gtk-contained-dark.css b/gtk/theme/Adwaita/gtk-contained-dark.css
index 7023c845c0..9b02dce917 100644
--- a/gtk/theme/Adwaita/gtk-contained-dark.css
+++ b/gtk/theme/Adwaita/gtk-contained-dark.css
@@ -505,7 +505,7 @@ spinbutton:not(.vertical) button:active { background-color: rgba(0, 0, 0, 0.1);
 
 spinbutton:not(.vertical) button:backdrop { color: #86898a; background-color: transparent; border-color: 
rgba(32, 36, 37, 0.3); transition: 200ms ease-out; }
 
-spinbutton:not(.vertical) button:backdrop:disabled { color: rgba(86, 97, 100, 0.3); background-color: 
transparent; border-style: none none none solid; }
+spinbutton:not(.vertical) button:backdrop:disabled { color: rgba(86, 97, 100, 0.3); background-color: 
transparent; background-image: none; border-style: none none none solid; }
 
 spinbutton:not(.vertical) button:backdrop:disabled:dir(rtl) { border-style: none solid none none; }
 
diff --git a/gtk/theme/Adwaita/gtk-contained.css b/gtk/theme/Adwaita/gtk-contained.css
index 5ece9e6869..e1e059f936 100644
--- a/gtk/theme/Adwaita/gtk-contained.css
+++ b/gtk/theme/Adwaita/gtk-contained.css
@@ -513,7 +513,7 @@ spinbutton:not(.vertical) button:active { background-color: rgba(0, 0, 0, 0.1);
 
 spinbutton:not(.vertical) button:backdrop { color: #96999a; background-color: transparent; border-color: 
rgba(192, 192, 189, 0.3); transition: 200ms ease-out; }
 
-spinbutton:not(.vertical) button:backdrop:disabled { color: rgba(195, 195, 192, 0.3); background-color: 
transparent; border-style: none none none solid; }
+spinbutton:not(.vertical) button:backdrop:disabled { color: rgba(195, 195, 192, 0.3); background-color: 
transparent; background-image: none; border-style: none none none solid; }
 
 spinbutton:not(.vertical) button:backdrop:disabled:dir(rtl) { border-style: none solid none none; }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]