[gimp/gimp-2-10] pdb: deprecate gimp_get_theme_dir() and gimp_get_icon_theme_dir()



commit 8dee1276f1ff121324c5af87f2f0e450ccfaa8ca
Author: Michael Natterer <mitch gimp org>
Date:   Fri Jan 4 15:55:47 2019 +0100

    pdb: deprecate gimp_get_theme_dir() and gimp_get_icon_theme_dir()
    
    They are unused in 2.10 and master, and we do this via the plug-in
    config message anyway.

 app/pdb/gimprc-cmds.c    | 12 ++++++++----
 libgimp/gimpgimprc_pdb.c |  4 ++++
 libgimp/gimpgimprc_pdb.h |  2 ++
 pdb/groups/gimprc.pdb    |  2 ++
 4 files changed, 16 insertions(+), 4 deletions(-)
---
diff --git a/app/pdb/gimprc-cmds.c b/app/pdb/gimprc-cmds.c
index 6a2466e7a6..9f81868b31 100644
--- a/app/pdb/gimprc-cmds.c
+++ b/app/pdb/gimprc-cmds.c
@@ -409,11 +409,13 @@ register_gimprc_procs (GimpPDB *pdb)
   gimp_procedure_set_static_strings (procedure,
                                      "gimp-get-theme-dir",
                                      "Get the directory of the current GUI theme.",
-                                     "Returns a copy of the current GUI theme dir.",
+                                     "Returns a copy of the current GUI theme dir.\n"
+                                     "\n"
+                                     "Deprecated: There is no replacement for this procedure.",
                                      "Spencer Kimball & Peter Mattis",
                                      "Spencer Kimball & Peter Mattis",
                                      "1995-1996",
-                                     NULL);
+                                     "NONE");
   gimp_procedure_add_return_value (procedure,
                                    gimp_param_spec_string ("theme-dir",
                                                            "theme dir",
@@ -433,11 +435,13 @@ register_gimprc_procs (GimpPDB *pdb)
   gimp_procedure_set_static_strings (procedure,
                                      "gimp-get-icon-theme-dir",
                                      "Get the directory of the current icon theme.",
-                                     "Returns a copy of the current icon theme dir.",
+                                     "Returns a copy of the current icon theme dir.\n"
+                                     "\n"
+                                     "Deprecated: There is no replacement for this procedure.",
                                      "Michael Natterer <mitch gimp org>",
                                      "Michael Natterer",
                                      "2015",
-                                     NULL);
+                                     "NONE");
   gimp_procedure_add_return_value (procedure,
                                    gimp_param_spec_string ("icon-theme-dir",
                                                            "icon theme dir",
diff --git a/libgimp/gimpgimprc_pdb.c b/libgimp/gimpgimprc_pdb.c
index eb799f5681..499b8fc280 100644
--- a/libgimp/gimpgimprc_pdb.c
+++ b/libgimp/gimpgimprc_pdb.c
@@ -215,6 +215,8 @@ gimp_get_monitor_resolution (gdouble *xres,
  *
  * Returns a copy of the current GUI theme dir.
  *
+ * Deprecated: There is no replacement for this procedure.
+ *
  * Returns: The GUI theme dir.
  **/
 gchar *
@@ -243,6 +245,8 @@ gimp_get_theme_dir (void)
  *
  * Returns a copy of the current icon theme dir.
  *
+ * Deprecated: There is no replacement for this procedure.
+ *
  * Returns: The icon theme dir.
  *
  * Since: 2.10
diff --git a/libgimp/gimpgimprc_pdb.h b/libgimp/gimpgimprc_pdb.h
index 526619838a..341204fd8c 100644
--- a/libgimp/gimpgimprc_pdb.h
+++ b/libgimp/gimpgimprc_pdb.h
@@ -39,7 +39,9 @@ gchar*                 gimp_get_default_comment      (void);
 GimpUnit               gimp_get_default_unit         (void);
 gboolean               gimp_get_monitor_resolution   (gdouble     *xres,
                                                       gdouble     *yres);
+GIMP_DEPRECATED
 gchar*                 gimp_get_theme_dir            (void);
+GIMP_DEPRECATED
 gchar*                 gimp_get_icon_theme_dir       (void);
 G_GNUC_INTERNAL gchar* _gimp_get_color_configuration (void);
 gchar*                 gimp_get_module_load_inhibit  (void);
diff --git a/pdb/groups/gimprc.pdb b/pdb/groups/gimprc.pdb
index 5bbebff304..4fdc56fb17 100644
--- a/pdb/groups/gimprc.pdb
+++ b/pdb/groups/gimprc.pdb
@@ -175,6 +175,7 @@ sub get_theme_dir {
     $help  = 'Returns a copy of the current GUI theme dir.';
 
     &std_pdb_misc;
+    $deprecated = 'NONE';
 
     @outargs = (
        {  name => 'theme_dir', type => 'string',
@@ -198,6 +199,7 @@ sub get_icon_theme_dir {
     $help  = 'Returns a copy of the current icon theme dir.';
 
     &mitch_pdb_misc('2015', '2.10');
+    $deprecated = 'NONE';
 
     @outargs = (
        {  name => 'icon_theme_dir', type => 'string',


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]