[gnome-photos/wip/rishi/libraw-explicit-build-options] flatpak: Explicitly specify the LibRaw build options
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-photos/wip/rishi/libraw-explicit-build-options] flatpak: Explicitly specify the LibRaw build options
- Date: Fri, 4 Jan 2019 11:00:29 +0000 (UTC)
commit b843015caddaf3276fa6c58015006d435ea011ed
Author: Debarshi Ray <debarshir gnome org>
Date: Fri Jan 4 11:52:21 2019 +0100
flatpak: Explicitly specify the LibRaw build options
Currently the build detects the presence of the necessary dependencies
and automatically enables or disables the corresponding options. Unless
someone is keeping a close eye on the build logs, a change in the
manifest or the SDK might silently and unexpectedly change the build
options.
Ideally, the build would fail if a requested option can't be met, to
draw attention to this unforeseen change.
Unfortunately, the LibRaw build uses AC_MSG_WARN even for explicitly
enabled build options. This means that a missing dependency won't fail
the build even if the option was explicitly requested. While this is
not ideal, at least listing the options makes it clear what the
required outcome is. That way someone can manually check the logs from
time to time and see if it's living up to the requirements.
The set of build flags have been chosen to match the current reality of
automatically selected options. Hence, there shouldn't be any
user-visible change.
https://gitlab.gnome.org/GNOME/gnome-photos/merge_requests/91
flatpak/org.gnome.Photos.json | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/flatpak/org.gnome.Photos.json b/flatpak/org.gnome.Photos.json
index 27919ead..4fc551f5 100644
--- a/flatpak/org.gnome.Photos.json
+++ b/flatpak/org.gnome.Photos.json
@@ -148,7 +148,12 @@
},
{
"name": "libraw",
- "config-opts": [ "--disable-examples", "--disable-static" ],
+ "config-opts": [ "--disable-examples",
+ "--disable-jasper",
+ "--disable-static",
+ "--enable-jpeg",
+ "--enable-lcms",
+ "--enable-openmp" ],
"cleanup": [ "/share/doc" ],
"sources": [
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]