[gnome-control-center/wip/privacy-a11y: 3/3] privacy: convert Mozilla link to a linkbutton



commit 74d82bf3a91ac2f3de76e935fc908daaa2e7f150
Author: Jeremy Bicha <jbicha ubuntu com>
Date:   Thu Jan 3 14:01:49 2019 -0500

    privacy: convert Mozilla link to a linkbutton
    
    This allows for it to be accessible via the keyboard

 panels/privacy/cc-privacy-panel.ui | 46 ++++++++++++++++++++++++++++----------
 1 file changed, 34 insertions(+), 12 deletions(-)
---
diff --git a/panels/privacy/cc-privacy-panel.ui b/panels/privacy/cc-privacy-panel.ui
index 8b9190176..246bc64fc 100644
--- a/panels/privacy/cc-privacy-panel.ui
+++ b/panels/privacy/cc-privacy-panel.ui
@@ -756,11 +756,11 @@ All the information we collect is made anonymous, and we will never share your d
           <object class="GtkBox">
             <property name="visible">True</property>
             <property name="orientation">vertical</property>
+            <property name="margin">12</property>
             <child>
               <object class="GtkLabel" id="location_description_label">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
-                <property name="margin_bottom">12</property>
                 <property name="label" translatable="yes">Location services allow applications to know your 
location. Using Wi-Fi and mobile broadband increases accuracy.</property>
                 <property name="wrap">True</property>
                 <property name="max_width_chars">50</property>
@@ -771,18 +771,40 @@ All the information we collect is made anonymous, and we will never share your d
               </object>
             </child>
             <child>
-              <object class="GtkLabel" id="location_privacy_policy_label">
+              <object class="GtkBox">
                 <property name="visible">True</property>
-                <property name="can_focus">False</property>
-                <property name="margin_bottom">12</property>
-                <property name="label" translatable="yes">Uses Mozilla Location Service: &lt;a 
href='https://location.services.mozilla.com/privacy'&gt;Privacy Policy&lt;/a&gt;</property>
-                <property name="use-markup">True</property>
-                <property name="wrap">True</property>
-                <property name="max_width_chars">50</property>
-                <property name="xalign">0</property>
-                <style>
-                  <class name="dim-label"/>
-                </style>
+                <child>
+                  <object class="GtkLabel" id="location_privacy_policy_label">
+                    <property name="visible">True</property>
+                    <property name="can_focus">False</property>
+                    <property name="label" translatable="yes">Uses Mozilla Location Service:</property>
+                    <property name="use-markup">True</property>
+                    <property name="wrap">True</property>
+                    <property name="max_width_chars">50</property>
+                    <style>
+                      <class name="dim-label"/>
+                    </style>
+                    <accessibility>
+                      <relation target="location_privacy_policy_button" type="label-for"/>
+                    </accessibility>
+                  </object>
+                </child>
+                <child>
+                  <object class="GtkLinkButton" id="location_privacy_policy_button">
+                    <property name="label" translatable="yes">Privacy Policy</property>
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="receives_default">True</property>
+                    <property name="relief">none</property>
+                    <property name="uri">https://location.services.mozilla.com/privacy</property>
+                    <style>
+                      <class name="dim-label"/>
+                    </style>
+                    <accessibility>
+                      <relation target="location_privacy_policy_label" type="labelled-by"/>
+                    </accessibility>
+                  </object>
+                </child>
               </object>
             </child>
           </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]