[vala/wip/transform: 114/124] Do not load plugins from libdir. Issue a warning when using --plugindir

[Rico Tzschichholz <ricotz src gnome org>]

commit 3cdad629ffe485d38c64f76aed6fd83448517063
Author: Luca Bruno <lucabru src gnome org>
Date:   Wed Feb 5 00:10:09 2014 +0100

    Do not load plugins from libdir. Issue a warning when using --plugindir

 configure.ac              | 1 -
 vala/Makefile.am          | 1 -
 vala/valacodecontext.vala | 6 ++++--
 vapi/config.vapi          | 1 -
 4 files changed, 4 insertions(+), 5 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 16ebd1f81..1c2b6f81a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -32,7 +32,6 @@ AC_DEFINE_UNQUOTED(PACKAGE_SUFFIX, "$PACKAGE_SUFFIX", [Define to the suffix of t
 program_transform_name="s,\$\$,${PACKAGE_SUFFIX},"
 
 AC_SUBST(pkgdatadir, [${datadir}/vala${PACKAGE_SUFFIX}])
-AC_SUBST(pkglibdir, [${libdir}/vala${PACKAGE_SUFFIX}])
 
 # Checks for programs.
 AC_PROG_CC
diff --git a/vala/Makefile.am b/vala/Makefile.am
index 774c7bb12..2c13f48d6 100644
--- a/vala/Makefile.am
+++ b/vala/Makefile.am
@@ -8,7 +8,6 @@ AM_CPPFLAGS = \
        $(GLIB_CFLAGS) \
        $(GMODULE_CFLAGS) \
        -DPACKAGE_DATADIR=\"$(pkgdatadir)\" \
-       -DPACKAGE_LIBDIR=\"$(pkglibdir)\"       \
        $(NULL)
 
 BUILT_SOURCES = vala.vala.stamp $(srcdir)/valaversion.vala
diff --git a/vala/valacodecontext.vala b/vala/valacodecontext.vala
index b7fa6ed35..705f9c79f 100644
--- a/vala/valacodecontext.vala
+++ b/vala/valacodecontext.vala
@@ -521,12 +521,14 @@ public class Vala.CodeContext {
                }
 
                if (plugin_directories != null) {
+                       if (!experimental) {
+                               Report.warning (null, "plugins are experimental and their API is unstable");
+                       }
+
                        foreach (string dir in plugin_directories) {
                                load_plugins_in_directory (dir);
                        }
                }
-
-               load_plugins_in_directory (Config.PACKAGE_LIBDIR);
        }
 
        public void load_plugins_in_directory (string dirname) {
diff --git a/vapi/config.vapi b/vapi/config.vapi
index 5ae26aab3..c8b5d58a1 100644
--- a/vapi/config.vapi
+++ b/vapi/config.vapi
@@ -23,7 +23,6 @@
 [CCode (cprefix = "", lower_case_cprefix = "", cheader_filename = "config.h")]
 namespace Config {
        public const string PACKAGE_DATADIR;
-       public const string PACKAGE_LIBDIR;
        public const string PACKAGE_SUFFIX;
        public const string PACKAGE_VALADOC_LIBDIR;
        public const string PACKAGE_VALADOC_ICONDIR;