[gnome-shell/wip/fmuellner/fix-aggregate-layout-width: 5/5] aggregateLayout: Fix natural width computation
- From: Jonas Ådahl <jadahl src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/fmuellner/fix-aggregate-layout-width: 5/5] aggregateLayout: Fix natural width computation
- Date: Tue, 26 Feb 2019 08:25:19 +0000 (UTC)
commit 70f4906ca5291e78708a8d3702b8c0a1d1c9d55a
Author: Florian Müllner <fmuellner gnome org>
Date: Mon Feb 25 23:31:45 2019 +0100
aggregateLayout: Fix natural width computation
Ouch, this went unnoticed for a long time: As the minimum size of menu
items is generally small (because its label can be ellipsized), we are
requesting the unellipsized width of the last "size child" instead of
the widest one.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/996
js/ui/panel.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/panel.js b/js/ui/panel.js
index f32e7f218..2e2a6592d 100644
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -729,7 +729,7 @@ class AggregateLayout extends Clutter.BoxLayout {
let child = this._sizeChildren[i];
let [childMin, childNat] = child.get_preferred_width(forHeight);
minWidth = Math.max(minWidth, childMin);
- natWidth = Math.max(minWidth, childNat);
+ natWidth = Math.max(natWidth, childNat);
}
return [minWidth, natWidth];
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]