[network-manager-applet/bg/wireless-hints-fix] wireless-security: 'unknown' method requires non-empty secrets



commit 9476fa6035deadabce04bb8277c65acc61ec117f
Author: Beniamino Galvani <bgalvani redhat com>
Date:   Wed Feb 20 10:17:27 2019 +0100

    wireless-security: 'unknown' method requires non-empty secrets
    
    secrets_hints can be a empty array when there are no hints.  See also
    similar commit [1] for nmcli secret agent.
    
    [1] 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/b32c03c879603ad6a8d53b083a932a9d525c0253
    
    Fixes: 0173934c831fac41d1203affd1fdf3d7fffeb22e

 src/wireless-security/wireless-security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/wireless-security/wireless-security.c b/src/wireless-security/wireless-security.c
index 257675c1..d1b69c22 100644
--- a/src/wireless-security/wireless-security.c
+++ b/src/wireless-security/wireless-security.c
@@ -499,7 +499,7 @@ ws_802_1x_auth_combo_init (WirelessSecurity *sec,
                active = item;
        item++;
 
-       if (secrets_hints) {
+       if (secrets_hints && secrets_hints[0]) {
                EAPMethodSimple *em_hints;
 
                em_hints = eap_method_simple_new (sec, connection, EAP_METHOD_SIMPLE_TYPE_UNKNOWN,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]