[libgda] Removing warnings

[Daniel Espinosa Ortiz <despinosa src gnome org>]

commit 08319b202ff2e585b6158a15bbcac3ec216b73a5
Author: Daniel Espinosa Ortiz <esodan gmail com>
Date:   Fri Feb 15 17:29:15 2019 -0600

    Removing warnings

 tests/providers/check_postgresql_ddl.c |  6 ---
 tools/browser/data-manager/analyser.c  |  4 +-
 tools/browser/mgr-favorites.c          | 78 +++++++++++++++++-----------------
 3 files changed, 41 insertions(+), 47 deletions(-)
---
diff --git a/tests/providers/check_postgresql_ddl.c b/tests/providers/check_postgresql_ddl.c
index 13e9dd8bb..7ee434c15 100644
--- a/tests/providers/check_postgresql_ddl.c
+++ b/tests/providers/check_postgresql_ddl.c
@@ -42,12 +42,6 @@ db_create_quark_foreach_func (gchar *name, gchar *value, GdaServerOperation *op)
        gda_server_operation_set_value_at (op, value, NULL, "/SERVER_CNX_P/%s", name);
 }
 
-static void 
-cnc_create_quark_foreach_func (gchar *name, gchar *value, GdaServerOperation *op)
-{
-       gda_server_operation_set_value_at (op, value, NULL, "/DB_DEF_P/%s", name);
-}
-
 static void
 postgresql_create_db_no_cnc(void)
 {
diff --git a/tools/browser/data-manager/analyser.c b/tools/browser/data-manager/analyser.c
index e28908bb5..856705423 100644
--- a/tools/browser/data-manager/analyser.c
+++ b/tools/browser/data-manager/analyser.c
@@ -190,7 +190,7 @@ compute_fk_dependency (GdaMetaTableForeignKey *fkey, GSList *selfields, gboolean
                                if (reverse) {
                                        if (!string) {
                                                string = g_string_new ("");
-                                               g_string_vprintf (string, _("Obtain referenced data in table 
%s from "),
+                                               g_string_printf (string, _("Obtain referenced data in table 
%s from "),
                                                                        fkey->depend_on->obj_short_name);
                                        }
                                        else
@@ -207,7 +207,7 @@ compute_fk_dependency (GdaMetaTableForeignKey *fkey, GSList *selfields, gboolean
                                else {
                                        if (!string) {
                                                string = g_string_new ("");
-                                               g_string_vprintf (string, _("List referencing data in %s."),
+                                               g_string_printf (string, _("List referencing data in %s."),
                                                                        fkey->meta_table->obj_short_name);
                                        }
                                        else
diff --git a/tools/browser/mgr-favorites.c b/tools/browser/mgr-favorites.c
index d264f4768..33349ad9d 100644
--- a/tools/browser/mgr-favorites.c
+++ b/tools/browser/mgr-favorites.c
@@ -353,7 +353,7 @@ hash_for_existing_nodes (const GSList *nodes)
        return hash;
 }
 
-static gboolean icons_resol_cb (MgrFavorites *mgr);
+//static gboolean icons_resol_cb (MgrFavorites *mgr);
 
 static GSList *
 mgr_favorites_update_children (GdaTreeManager *manager, GdaTreeNode *node, const GSList *children_nodes,
@@ -780,41 +780,41 @@ mgr_favorites_update_children (GdaTreeManager *manager, GdaTreeNode *node, const
        return g_slist_reverse (nodes_list);
 }
 
-#ifdef HAVE_LDAP
-static gboolean
-icons_resol_cb (MgrFavorites *mgr)
-{
-        if (mgr->priv->icons_resol_timer == 0)
-                return FALSE;
-        if (mgr->priv->icons_resol_list) {
-                IconResolutionData *data;
-                data = (IconResolutionData*) mgr->priv->icons_resol_list->data;
-                mgr->priv->icons_resol_list = g_slist_delete_link (mgr->priv->icons_resol_list,
-                                                                   mgr->priv->icons_resol_list);
-
-               GdkPixbuf *pixbuf;
-               pixbuf = ui_connection_ldap_icon_for_dn (mgr->priv->tcnc, data->dn, NULL);
-               if (pixbuf) {
-                       GValue *av;
-                       av = gda_value_new (G_TYPE_OBJECT);
-                       g_value_set_object (av, pixbuf);
-                       gda_tree_node_set_node_attribute ((GdaTreeNode*) data->node, "icon", av, NULL);
-                       gda_value_free (av);
-               }
-                icon_resolution_data_free (data);
-        }
-
-        if (! mgr->priv->icons_resol_list) {
-                mgr->priv->icons_resol_timer = 0;
-                return FALSE;
-        }
-        else
-                return TRUE;
-}
-#else
-static gboolean
-icons_resol_cb (MgrFavorites *mgr)
-{
-  return FALSE;
-}
-#endif
+//#ifdef HAVE_LDAP
+/* static gboolean */
+/* icons_resol_cb (MgrFavorites *mgr) */
+/* { */
+/*         if (mgr->priv->icons_resol_timer == 0) */
+/*                 return FALSE; */
+/*         if (mgr->priv->icons_resol_list) { */
+/*                 IconResolutionData *data; */
+/*                 data = (IconResolutionData*) mgr->priv->icons_resol_list->data; */
+/*                 mgr->priv->icons_resol_list = g_slist_delete_link (mgr->priv->icons_resol_list, */
+/*                                                                    mgr->priv->icons_resol_list); */
+
+/*             GdkPixbuf *pixbuf; */
+/*             pixbuf = ui_connection_ldap_icon_for_dn (mgr->priv->tcnc, data->dn, NULL); */
+/*             if (pixbuf) { */
+/*                     GValue *av; */
+/*                     av = gda_value_new (G_TYPE_OBJECT); */
+/*                     g_value_set_object (av, pixbuf); */
+/*                     gda_tree_node_set_node_attribute ((GdaTreeNode*) data->node, "icon", av, NULL); */
+/*                     gda_value_free (av); */
+/*             } */
+/*                 icon_resolution_data_free (data); */
+/*         } */
+
+/*         if (! mgr->priv->icons_resol_list) { */
+/*                 mgr->priv->icons_resol_timer = 0; */
+/*                 return FALSE; */
+/*         } */
+/*         else */
+/*                 return TRUE; */
+/* } */
+//#else
+//static gboolean
+/* icons_resol_cb (MgrFavorites *mgr) */
+/* { */
+/*   return FALSE; */
+/* } */
+//#endif