[gnome-keysign: 3/5] sign-key: Actually print to stdout that we are waiting for the user



commit 0fc5abb82f703f7408a9c6c6826c35e591a580a0
Author: Tobias Mueller <muelli cryptobitch de>
Date:   Thu Feb 14 13:08:55 2019 +0100

    sign-key: Actually print to stdout that we are waiting for the user
    
    It seems silly to have logged that statement. If only because the log
    level can cause the message to not be printed at all. And that is what
    happened.  Now we use print() which should certainly make the message
    land on the user's screen.  We could think about using stderr, but let's
    not overengineer this for now.

 keysign/SignKey.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/keysign/SignKey.py b/keysign/SignKey.py
index 11cb22f..cc14c96 100755
--- a/keysign/SignKey.py
+++ b/keysign/SignKey.py
@@ -38,7 +38,7 @@ def main():
         data = fhandle.read()
         log.info("Calling %r to sign %s", sign_keydata_and_send, fhandle.name)
         tmpfiles = list(sign_keydata_and_send(keydata=data))
-    log.info("Finished signing. " +
+    print("Finished signing. " +
              "We're only waiting for the signature " +
              "files to be picked up. " +
              "Press any key to quit the application.")


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]