[gnome-shell/wip/fmuellner/app-menu-refinement] appIconMenu: Sync windows section with app menu

[Florian Müllner <fmuellner src gnome org>]

commit 021057c62a85b1b9d1dcb761f6ca6c9ef106a6a9
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Feb 12 13:37:39 2019 +0100

    appIconMenu: Sync windows section with app menu
    
    Keep the app icon context menu consistent with the app menu, so stop
    grouping windows by workspace and add a section heading.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/968

 js/ui/appDisplay.js | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index adaefa7dd..16df9ca0d 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1707,25 +1707,20 @@ var AppIconMenu = class AppIconMenu extends PopupMenu.PopupMenu {
             w => !w.skip_taskbar
         );
 
-        // Display the app windows menu items and the separator between windows
-        // of the current desktop and other windows.
-        let workspaceManager = global.workspace_manager;
-        let activeWorkspace = workspaceManager.get_active_workspace();
-        let separatorShown = windows.length > 0 && windows[0].get_workspace() != activeWorkspace;
-
-        for (let i = 0; i < windows.length; i++) {
-            let window = windows[i];
-            if (!separatorShown && window.get_workspace() != activeWorkspace) {
-                this._appendSeparator();
-                separatorShown = true;
-            }
+        if (windows.length > 0)
+            this.addMenuItem(
+                /* Translators: This is the heading of a list of open windows */
+                new PopupMenu.PopupSeparatorMenuItem(_("Open Windows"))
+            );
+
+        windows.forEach(window => {
             let title = window.title ? window.title
                                      : this._source.app.get_name();
             let item = this._appendMenuItem(title);
             item.connect('activate', () => {
                 this.emit('activate-window', window);
             });
-        }
+        });
 
         if (!this._source.app.is_window_backed()) {
             this._appendSeparator();