[gnome-settings-daemon/wip/claudio/CI] power: Let stderr output of gsd-power test process go outside



commit c087f272fee91dc2f422fc12e535f791ac0479bc
Author: Benjamin Berg <bberg redhat com>
Date:   Tue Feb 5 17:32:16 2019 +0100

    power: Let stderr output of gsd-power test process go outside
    
    We used to redirect it into stdout which goes into a separate log.
    However, stderr is generally useful to see, and we actually need to see
    it for ASAN checking. So always let stderr go through for the gsd-power
    test process.

 plugins/power/test.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/plugins/power/test.py b/plugins/power/test.py
index b9873579..8e3bde86 100755
--- a/plugins/power/test.py
+++ b/plugins/power/test.py
@@ -124,11 +124,12 @@ class PowerPluginBase(gsdtestcase.GSDTestCase):
             else:
                 env['LD_PRELOAD'] = env['POWER_LD_PRELOAD']
 
+        # We need to redirect stdout to grab the debug messages.
+        # stderr is not needed by the testing infrastructure but is useful to
+        # see warnings and errors.
         self.daemon = subprocess.Popen(
             [os.path.join(builddir, 'gsd-power'), '--verbose'],
-            # comment out this line if you want to see the logs in real time
             stdout=self.plugin_log_write,
-            stderr=subprocess.STDOUT,
             env=env)
 
         # you can use this for reading the current daemon log in tests


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]