[gnome-shell/gnome-3-30] panel: Don't allow opening hidden menus via keybindings



commit 511e8c658445377b044c6dfb241709142c97a8ce
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Jan 23 23:55:12 2019 +0100

    panel: Don't allow opening hidden menus via keybindings
    
    We shouldn't allow toggling menus that aren't supported by the
    current session mode, but as indicators are hidden rather than
    destroyed on mode switches, it is not enough to check for an
    indicator's existence.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/issues/851

 js/ui/panel.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/panel.js b/js/ui/panel.js
index 66588f9c1..5b2ee63d8 100644
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -998,8 +998,8 @@ var Panel = new Lang.Class({
     },
 
     _toggleMenu(indicator) {
-        if (!indicator) // menu not supported by current session mode
-            return;
+        if (!indicator || !indicator.container.visible)
+            return; // menu not supported by current session mode
 
         let menu = indicator.menu;
         if (!indicator.actor.reactive)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]