[glib/mcatanzaro/rehandshake] Fully deprecate TLS rehandshakes



commit 7796f88d0b801c3e1267ce9468c7b93a516d666a
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Sun Dec 29 14:28:30 2019 -0600

    Fully deprecate TLS rehandshakes
    
    Previously, the documentation indicated that it was possible to call
    g_tls_connection_handshake() after an initial handshake to trigger a
    rehandshake, but only if TLS 1.2 or older is in use. However, there is
    no documented way to ensure TLS 1.2 gets used. Nowadays, TLS 1.3 is used
    by default.
    
    I'm removing support for rehandshaking from glib-networking, as part of
    a large refactoring where keeping rehandshakes would have entailed
    significant additional complexity. So let's update the documentation to
    indicate this is no longer ever supported. Applications should not
    notice any difference.

 gio/gdtlsconnection.c | 11 +++++------
 gio/gtlsconnection.c  | 11 +++++------
 2 files changed, 10 insertions(+), 12 deletions(-)
---
diff --git a/gio/gdtlsconnection.c b/gio/gdtlsconnection.c
index 1a74e3cc4..b84470627 100644
--- a/gio/gdtlsconnection.c
+++ b/gio/gdtlsconnection.c
@@ -705,12 +705,11 @@ G_GNUC_END_IGNORE_DEPRECATIONS
  * the beginning of the communication, you do not need to call this
  * function explicitly unless you want clearer error reporting.
  *
- * If TLS 1.2 or older is in use, you may call
- * g_dtls_connection_handshake() after the initial handshake to
- * rehandshake; however, this usage is deprecated because rehandshaking
- * is no longer part of the TLS protocol in TLS 1.3. Accordingly, the
- * behavior of calling this function after the initial handshake is now
- * undefined, except it is guaranteed to be reasonable and
+ * Previously, calling g_dtls_connection_handshake() after the initial
+ * handshake would trigger a rehandshake; however, this usage was
+ * deprecated in GLib 2.60 because rehandshaking was removed from the
+ * TLS protocol in TLS 1.3. The behavior of calling this function after
+ * the initial handshake is now undefined, except it is guaranteed to be
  * nondestructive so as to preserve compatibility with code written for
  * older versions of GLib.
  *
diff --git a/gio/gtlsconnection.c b/gio/gtlsconnection.c
index 5bdea96e5..69e1401e1 100644
--- a/gio/gtlsconnection.c
+++ b/gio/gtlsconnection.c
@@ -902,12 +902,11 @@ g_tls_connection_get_negotiated_protocol (GTlsConnection *conn)
  * the beginning of the communication, you do not need to call this
  * function explicitly unless you want clearer error reporting.
  *
- * If TLS 1.2 or older is in use, you may call
- * g_tls_connection_handshake() after the initial handshake to
- * rehandshake; however, this usage is deprecated because rehandshaking
- * is no longer part of the TLS protocol in TLS 1.3. Accordingly, the
- * behavior of calling this function after the initial handshake is now
- * undefined, except it is guaranteed to be reasonable and
+ * Previously, calling g_tls_connection_handshake() after the initial
+ * handshake would trigger a rehandshake; however, this usage was
+ * deprecated in GLib 2.60 because rehandshaking was removed from the
+ * TLS protocol in TLS 1.3. The behavior of calling this function after
+ * the initial handshake is now undefined, except it is guaranteed to be
  * nondestructive so as to preserve compatibility with code written for
  * older versions of GLib.
  *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]