[eog-plugins: 1/2] export-to-folder: Use file-set signal to change target directory
- From: Felix Riemann <friemann src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [eog-plugins: 1/2] export-to-folder: Use file-set signal to change target directory
- Date: Sat, 28 Dec 2019 23:33:59 +0000 (UTC)
commit 676d80ce93c41e760d5b013c767607221be4583d
Author: Anton Leontiev <scileont gmail com>
Date: Mon Oct 14 08:44:11 2019 +0300
export-to-folder: Use file-set signal to change target directory
Currently changing target directory from GUI doesn't always work. If
user chooses directory from drop-down list of GtkFileChooserButton,
'current-folder-changed' signal isn't emitted and configuration isn't
updated.
Instead of using 'current-folder-changed' signal from GtkFileChooser
interface, use 'file-set' signal from GtkFileChooserButton.
Furthermore get_currect_folder() doesn't correspond to the selected
folder, but to the folder containing selected folder. Therefore it is
changed to get_filename(). For more info see manual for
gtk_file_chooser_get_current_folder().
plugins/export-to-folder/export-to-folder.py | 8 ++++----
plugins/export-to-folder/preferences_dialog.ui | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/plugins/export-to-folder/export-to-folder.py b/plugins/export-to-folder/export-to-folder.py
index a6e8b5e..3b383d5 100644
--- a/plugins/export-to-folder/export-to-folder.py
+++ b/plugins/export-to-folder/export-to-folder.py
@@ -125,7 +125,7 @@ class ExportConfigurable(GObject.Object, PeasGtk.Configurable):
def do_create_configure_widget(self):
# Create preference dialog
- signals = {'current_folder_changed_cb': self.current_folder_changed_cb}
+ signals = {'file_set_cb': self.file_set_cb}
builder = Gtk.Builder()
builder.set_translation_domain('eog-plugins')
builder.add_from_file(os.path.join(self.plugin_info.get_data_dir(),
@@ -137,9 +137,9 @@ class ExportConfigurable(GObject.Object, PeasGtk.Configurable):
target_dir = self.settings.get_string('target-folder')
if target_dir == "":
target_dir = EXPORT_DIR
- self.export_dir_button.set_current_folder(target_dir)
+ self.export_dir_button.set_filename(target_dir)
return self.preferences_dialog
- def current_folder_changed_cb(self, button):
- self.settings.set_string('target-folder', button.get_current_folder())
+ def file_set_cb(self, button):
+ self.settings.set_string('target-folder', button.get_filename())
diff --git a/plugins/export-to-folder/preferences_dialog.ui b/plugins/export-to-folder/preferences_dialog.ui
index a94d71a..fd02f83 100644
--- a/plugins/export-to-folder/preferences_dialog.ui
+++ b/plugins/export-to-folder/preferences_dialog.ui
@@ -29,7 +29,7 @@
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="action">select-folder</property>
- <signal name="current-folder-changed" handler="current_folder_changed_cb" swapped="no"/>
+ <signal name="file-set" handler="file_set_cb" swapped="no"/>
</object>
<packing>
<property name="expand">False</property>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]